From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: davem@davemloft•net, Todd Fujinaka <todd.fujinaka@intel•com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel•com>,
netdev@vger•kernel.org, gospo@redhat•com, sassmann@redhat•com
Subject: Re: [net 5/7] igb: fix stats for i210 rx_fifo_errors
Date: Sun, 20 Apr 2014 01:58:23 +0400 [thread overview]
Message-ID: <5352F17F.3080907@cogentembedded.com> (raw)
In-Reply-To: <1397872767-4001-6-git-send-email-jeffrey.t.kirsher@intel.com>
Hello.
On 04/19/2014 05:59 AM, Jeff Kirsher wrote:
> From: Todd Fujinaka <todd.fujinaka@intel•com>
> RQDPC on i210/i211 is R/W not ReadClear. Clear after reading.
> Signed-off-by: Todd Fujinaka <todd.fujinaka@intel•com>
> Tested-by: Aaron Brown <aaron.f.brown@intel•com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel•com>
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
> index fb98d46..16430a8 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -5193,8 +5193,10 @@ void igb_update_stats(struct igb_adapter *adapter,
>
> rcu_read_lock();
> for (i = 0; i < adapter->num_rx_queues; i++) {
> - u32 rqdpc = rd32(E1000_RQDPC(i));
> struct igb_ring *ring = adapter->rx_ring[i];
> + u32 rqdpc = rd32(E1000_RQDPC(i));
Empty line needed after declaration. It was present before this patch.
> + if (hw->mac.type >= e1000_i210)
> + wr32(E1000_RQDPC(i), 0);
>
> if (rqdpc) {
> ring->rx_stats.drops += rqdpc;
WBR, Sergei
next prev parent reply other threads:[~2014-04-19 21:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-19 1:59 [net 0/7][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2014-04-19 1:59 ` [net 1/7] i40e: remove open-coded skb_cow_head Jeff Kirsher
2014-04-19 1:59 ` [net 2/7] i40e: fix TCP flag replication for hardware offload Jeff Kirsher
2014-04-19 1:59 ` [net 3/7] e1000e: Correctly include VLAN_HLEN when changing interface MTU Jeff Kirsher
2014-04-19 1:59 ` [net 4/7] e1000e: Enclose e1000e_pm_thaw() with CONFIG_PM_SLEEP Jeff Kirsher
2014-04-19 1:59 ` [net 5/7] igb: fix stats for i210 rx_fifo_errors Jeff Kirsher
2014-04-19 21:58 ` Sergei Shtylyov [this message]
2014-04-19 1:59 ` [net 6/7] ixgbe: clean up Rx time stamping code Jeff Kirsher
2014-04-19 1:59 ` [net 7/7] e1000e/igb/ixgbe/i40e: fix message terminations Jeff Kirsher
2014-04-21 16:58 ` [net 0/7][pull request] Intel Wired LAN Driver Updates David Miller
2014-04-21 20:15 ` Or Gerlitz
2014-04-21 20:24 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5352F17F.3080907@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gospo@redhat$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sassmann@redhat$(echo .)com \
--cc=todd.fujinaka@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox