From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6•org>
To: Lorenzo Colitti <lorenzo@google•com>, netdev@vger•kernel.org
Cc: hannes@stressinduktion•org, davem@davemloft•net,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6•org>
Subject: Re: [PATCH net-next 1/3] net: ipv6: unduplicate {raw,udp}v6_sendmsg code
Date: Tue, 22 Apr 2014 18:06:39 +0900 [thread overview]
Message-ID: <5356311F.6080901@linux-ipv6.org> (raw)
In-Reply-To: <1398154415-24486-1-git-send-email-lorenzo@google.com>
Lorenzo Colitti wrote:
> rawv6_sendmsg and udpv6_sendmsg have ~100 lines of almost
> identical code. Move this into a new ipv6_datagram_send_common
> helper function.
>
> Tested: black-box tested using user-mode Linux.
>
> - Basic UDP sends using sendto work.
> - Mark routing and oif routing using SO_BINDTODEVICE work.
>
> Signed-off-by: Lorenzo Colitti <lorenzo@google•com>
> ---
> include/net/ipv6.h | 7 +++
> net/ipv6/datagram.c | 131 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> net/ipv6/raw.c | 107 ++++--------------------------------------
> net/ipv6/udp.c | 117 ++++------------------------------------------
> 4 files changed, 154 insertions(+), 208 deletions(-)
>
:
> --- a/net/ipv6/datagram.c
> +++ b/net/ipv6/datagram.c
> @@ -915,6 +915,137 @@ exit_f:
> }
> EXPORT_SYMBOL_GPL(ip6_datagram_send_ctl);
>
> +int ip6_datagram_send_common(struct sock *sk, struct msghdr *msg,
> + struct sockaddr_in6 *sin6, int addr_len,
> + struct flowi6 *fl6, struct dst_entry **dstp,
> + struct ipv6_txoptions **optp,
> + struct ipv6_txoptions *opt_space,
> + int *hlimit, int *tclass, int *dontfrag,
> + int *connected) {
Put this opening brace at the beginning of the next line, please.
--yoshfuji
next prev parent reply other threads:[~2014-04-22 9:06 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 8:13 [PATCH net-next 1/3] net: ipv6: unduplicate {raw,udp}v6_sendmsg code Lorenzo Colitti
2014-04-22 8:13 ` [PATCH net-next 2/3] net: ipv6: Use ip6_datagram_send_common in L2TP IPv6 Lorenzo Colitti
2014-04-22 8:13 ` [PATCH net-next 3/3] net: ipv6: Use ip6_datagram_send_common in ping Lorenzo Colitti
2014-04-22 9:06 ` YOSHIFUJI Hideaki [this message]
2014-04-22 9:38 ` [PATCH net-next v2 1/3] net: ipv6: unduplicate {raw,udp}v6_sendmsg code Lorenzo Colitti
2014-04-22 9:38 ` [PATCH net-next v2 2/3] net: ipv6: Use ip6_datagram_send_common in L2TP IPv6 Lorenzo Colitti
2014-04-22 14:23 ` Eric Dumazet
2014-04-22 15:11 ` Lorenzo Colitti
2014-04-22 9:38 ` [PATCH net-next v2 3/3] net: ipv6: Use ip6_datagram_send_common in ping Lorenzo Colitti
2014-04-22 15:14 ` [PATCH net-next v3 1/3] net: ipv6: Unduplicate {raw,udp}v6_sendmsg code Lorenzo Colitti
2014-04-22 15:14 ` [PATCH net-next v3 2/3] net: ipv6: Use ip6_datagram_send_common in L2TP IPv6 Lorenzo Colitti
2014-04-22 15:14 ` [PATCH net-next v3 3/3] net: ipv6: Use ip6_datagram_send_common in ping Lorenzo Colitti
2014-04-22 15:48 ` [PATCH net-next v3 1/3] net: ipv6: Unduplicate {raw,udp}v6_sendmsg code Hannes Frederic Sowa
2014-04-23 6:37 ` Lorenzo Colitti
2014-04-22 15:59 ` Eric Dumazet
2014-04-23 6:38 ` Lorenzo Colitti
2014-04-23 6:37 ` [PATCH net-next v4 " Lorenzo Colitti
2014-04-23 6:37 ` [PATCH net-next v4 2/3] net: ipv6: Use ip6_datagram_send_common in L2TP IPv6 Lorenzo Colitti
2014-04-23 6:37 ` [PATCH net-next v4 3/3] net: ipv6: Use ip6_datagram_send_common in ping Lorenzo Colitti
2014-04-23 11:11 ` Florent Fourcot
2014-04-23 12:22 ` Lorenzo Colitti
2014-04-24 15:06 ` Hannes Frederic Sowa
2014-04-24 15:35 ` Lorenzo Colitti
2014-04-24 16:06 ` Lorenzo Colitti
2014-04-24 15:00 ` [PATCH net-next v4 1/3] net: ipv6: Unduplicate {raw,udp}v6_sendmsg code Hannes Frederic Sowa
2014-04-24 15:02 ` Hannes Frederic Sowa
2014-04-24 15:13 ` Lorenzo Colitti
2014-04-24 15:43 ` Hannes Frederic Sowa
2014-04-25 11:09 ` Lorenzo Colitti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5356311F.6080901@linux-ipv6.org \
--to=yoshfuji@linux-ipv6$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=hannes@stressinduktion$(echo .)org \
--cc=lorenzo@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox