public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stefan Wahren <stefan.wahren@i2se•com>
To: Ben Hutchings <ben@decadent•org.uk>
Cc: Stefan Wahren <info@lategoodbye•de>, netdev@vger•kernel.org
Subject: Re: Porting ethernet over spi driver
Date: Tue, 22 Apr 2014 12:02:36 +0200	[thread overview]
Message-ID: <53563E3C.3030108@i2se.com> (raw)
In-Reply-To: <1398133328.3624.186.camel@deadeye.wl.decadent.org.uk>

Am 22.04.2014 04:22, schrieb Ben Hutchings:
> On Fri, 2014-04-18 at 11:17 +0200, Stefan Wahren wrote:
>> Hi,
>>
>> i'm trying to port a ethernet over spi driver to current mainline, which 
>> originally based on kernel 2.6.
>>
>> Now i'm searching for some guidelines, checklists, common pitfalls or 
>> just hints about that.
>>
>> Is there something about that, which is up to date?
> I don't think there is.
>
>> Is there a list or something of legacy function, which shouldn't be used 
>> anymore?
> No but the compiler should tell you about functions that were removed!
>
>> Are there any new must have features?
> You don't say which 2.6.y version you started with, but API changes I
> can think of that come up when backporting are:

Sorry for being so imprecise, it is 2.6.35.

> - 2.6.24: NAPI now involves a napi_struct rather than fields in
> net_device
> - 2.6.29: net device operation pointers moved into struct net_device_ops
> - 2.6.29: GRO added (can be useful if you have RX checksum offload)
> - 2.6.36: ndo_get_stats64 added as alternative to ndo_get_stats
> - 2.6.37: vlan_hwaccel_* functions removed; the driver must attach the
> tag and call the regular receive function
> - 2.6.39: ethtool feature setting replaced by net device operations
> ndo_fix_features & ndo_set_features
> - 3.2: ndo_set_multicast_list and ndo_set_rx_mode operations merged
> - 3.10: VLAN functions and feature flags changed to allow for both
> 802.1q and 802.1ad tags

Thank you for this list.

> Most of the interesting new features are related to multiqueue and
> protocol offloads that I wouldn't expect to exist in an SPI-attached
> Ethernet controller.  

You are right.

Btw, is simple power management (suspend, resume) a must-have feature?

BR Stefan Wahren

  reply	other threads:[~2014-04-22 10:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-18  9:17 Porting ethernet over spi driver Stefan Wahren
2014-04-22  2:22 ` Ben Hutchings
2014-04-22 10:02   ` Stefan Wahren [this message]
2014-04-22 15:21     ` Ben Hutchings
2014-04-25  7:24       ` Porting ethernet over spi driver (powerline device) Stefan Wahren
2014-04-26 13:45         ` Ben Hutchings
2014-04-22  2:32 ` Porting ethernet over spi driver Fabio Estevam
2014-04-22  9:42   ` Stefan Wahren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53563E3C.3030108@i2se.com \
    --to=stefan.wahren@i2se$(echo .)com \
    --cc=ben@decadent$(echo .)org.uk \
    --cc=info@lategoodbye$(echo .)de \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox