From: Jamal Hadi Salim <jhs@mojatatu•com>
To: Cong Wang <xiyou.wangcong@gmail•com>
Cc: Linux Kernel Network Developers <netdev@vger•kernel.org>,
"David S. Miller" <davem@davemloft•net>,
Cong Wang <cwang@twopensource•com>
Subject: Re: [Patch net] sched, cls: check if we could overwrite actions when changing a filter
Date: Fri, 25 Apr 2014 11:48:26 -0400 [thread overview]
Message-ID: <535A83CA.4030201@mojatatu.com> (raw)
In-Reply-To: <CAM_iQpXkihRZN8Uf=KtaFexF1JP66Fztr+q3_tT4sMgOLMxGGQ@mail.gmail.com>
On 04/24/14 17:12, Cong Wang wrote:
> On Wed, Apr 23, 2014 at 4:30 AM, Jamal Hadi Salim <jhs@mojatatu•com> wrote:
>>
>> I dont see what you are seeing. However, some quick tests will prove it.
>> Example go from 1->3 actions and backwards 3->1 actions.
>> I.e create a policy with (handwave) 3 actions and replace it with
>> another that has only one action. Do this while you are sending a
>> ping exercising this policy.
>> I can see how yours with 1->0 and 0->1 will work.
>
> See below (with this patch applied):
>
Ok, thanks Cong. Since you are using this in your system already,
I am assuming it is tested with running traffic at the same time.
Please resubmit the patch with my signed off as well..
cheers,
jamal
next prev parent reply other threads:[~2014-04-25 15:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 23:46 [Patch net] sched, cls: check if we could overwrite actions when changing a filter Cong Wang
2014-04-16 12:30 ` Jamal Hadi Salim
2014-04-16 21:10 ` Cong Wang
2014-04-17 11:50 ` Jamal Hadi Salim
2014-04-17 20:48 ` Cong Wang
2014-04-18 14:26 ` Jamal Hadi Salim
2014-04-18 17:18 ` Cong Wang
2014-04-19 11:10 ` Jamal Hadi Salim
2014-04-21 23:28 ` Cong Wang
2014-04-23 11:30 ` Jamal Hadi Salim
2014-04-24 21:12 ` Cong Wang
2014-04-25 15:48 ` Jamal Hadi Salim [this message]
2014-04-25 20:41 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535A83CA.4030201@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=cwang@twopensource$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox