public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Roopa Prabhu <roopa@cumulusnetworks•com>
To: netdev <netdev@vger•kernel.org>
Cc: Jiri Pirko <jiri@resnulli•us>, Thomas Graf <tgraf@suug•ch>,
	David Miller <davem@davemloft•net>
Subject: Question regarding bond delete notifications
Date: Sat, 26 Apr 2014 23:16:27 -0700	[thread overview]
Message-ID: <535CA0BB.1010504@cumulusnetworks.com> (raw)

Hello,

I am seeing a problem with the order of rtnl link notifications during 
bond deletes.
If i delete a bond without deleting its slaves, kernel sends a 
RTM_DELLINK during unregister_netdevice
(in rollback_registered_many) and then calls bond_uninit (ndo_uninit).
bond_uninit inturn cleans up the slaves and generates a few RTM_NEWLINK 
rtnl notifications for NETDEV_CHANGEADDR and NETDEV_FEAT_CHANGE for the 
bond device.

This is confusing to userspace listening for rtnl LINK Notifications.
For example, libnl gets confused with RTM_NEWLINK arriving after 
RTM_DELLINK.
The RTM_NEWLINK makes libnl believe that this is a new bond link. But 
kernel has already deleted the bond device.

It seems like the kernel should  generate RTM_DELLINK notification after 
ndo_uninit. something like below.
But am not sure if this change is safe for other netdevices.

Is this a known problem ?. Any suggestions ?

Thanks,
Roopa

diff --git a/net/core/dev.c b/net/core/dev.c
index b1b0c8d..85cb73a 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -5568,33 +5568,33 @@ static void rollback_registered_many(struct 
list_head *head)
     list_for_each_entry(dev, head, unreg_list) {
         /* Shutdown queueing discipline. */
         dev_shutdown(dev);


         /* Notify protocols, that we are about to destroy
            this device. They should clean all the things.
         */
         call_netdevice_notifiers(NETDEV_UNREGISTER, dev);

-       if (!dev->rtnl_link_ops ||
-           dev->rtnl_link_state == RTNL_LINK_INITIALIZED)
-           rtmsg_ifinfo(RTM_DELLINK, dev, ~0U, GFP_KERNEL);
-
         /*
          *  Flush the unicast and multicast chains
          */
         dev_uc_flush(dev);
         dev_mc_flush(dev);

         if (dev->netdev_ops->ndo_uninit)
             dev->netdev_ops->ndo_uninit(dev);

+       if (!dev->rtnl_link_ops ||
+           dev->rtnl_link_state == RTNL_LINK_INITIALIZED)
+           rtmsg_ifinfo(RTM_DELLINK, dev, ~0U, GFP_KERNEL);
+
         /* Notifier chain MUST detach us all upper devices. */
         WARN_ON(netdev_has_any_upper_dev(dev));

         /* Remove entries from kobject tree */
         netdev_unregister_kobject(dev);
  #ifdef CONFIG_XPS
         /* Remove XPS queueing entries */
         netif_reset_xps_queues_gt(dev, 0);
  #endif
     }

             reply	other threads:[~2014-04-27  6:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-27  6:16 Roopa Prabhu [this message]
2014-04-30  6:31 ` Question regarding bond delete notifications Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=535CA0BB.1010504@cumulusnetworks.com \
    --to=roopa@cumulusnetworks$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=jiri@resnulli$(echo .)us \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=tgraf@suug$(echo .)ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox