From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail•com>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons•com>,
netdev@vger•kernel.org
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons•com>,
Gregory Clement <gregory.clement@free-electrons•com>,
Tawfik Bayouk <tawfik@marvell•com>,
Lior Amsalem <alior@marvell•com>,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH v2 for v3.15] net: mvmdio: Check for a valid interrupt instead of an error
Date: Wed, 30 Apr 2014 21:40:57 +0200 [thread overview]
Message-ID: <536151C9.4090802@gmail.com> (raw)
In-Reply-To: <1398875331-18925-1-git-send-email-ezequiel.garcia@free-electrons.com>
On 04/30/2014 06:28 PM, Ezequiel Garcia wrote:
> The following commit:
>
> commit 9ec36cafe43bf835f8f29273597a5b0cbc8267ef
> Author: Rob Herring <robh@kernel•org>
> Date: Wed Apr 23 17:57:41 2014 -0500
>
> of/irq: do irq resolution in platform_get_irq
>
> changed platform_get_irq() which now returns EINVAL and EPROBE_DEFER,
> in addition to ENXIO. If there's no interrupt for mvmdio, platform_get_irq()
> returns EINVAL, but we currently check only for ENXIO.
>
> Fix this by looking for a positive integer, which is the proper way of
> validating a virtual interrupt number.
>
> While at it, add a proper handling for the deferral probe case.
>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons•com>
Reviewed-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail•com>
Thanks!
> ---
> Changes from v1: Handle the deferral probe as well.
>
> drivers/net/ethernet/marvell/mvmdio.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/mvmdio.c b/drivers/net/ethernet/marvell/mvmdio.c
> index b161a52..9d5ced2 100644
> --- a/drivers/net/ethernet/marvell/mvmdio.c
> +++ b/drivers/net/ethernet/marvell/mvmdio.c
> @@ -232,7 +232,7 @@ static int orion_mdio_probe(struct platform_device *pdev)
> clk_prepare_enable(dev->clk);
>
> dev->err_interrupt = platform_get_irq(pdev, 0);
> - if (dev->err_interrupt != -ENXIO) {
> + if (dev->err_interrupt > 0) {
> ret = devm_request_irq(&pdev->dev, dev->err_interrupt,
> orion_mdio_err_irq,
> IRQF_SHARED, pdev->name, dev);
> @@ -241,6 +241,9 @@ static int orion_mdio_probe(struct platform_device *pdev)
>
> writel(MVMDIO_ERR_INT_SMI_DONE,
> dev->regs + MVMDIO_ERR_INT_MASK);
> +
> + } else if (dev->err_interrupt == -EPROBE_DEFER) {
> + return -EPROBE_DEFER;
> }
>
> mutex_init(&dev->lock);
>
next prev parent reply other threads:[~2014-04-30 19:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 16:28 [PATCH v2 for v3.15] net: mvmdio: Check for a valid interrupt instead of an error Ezequiel Garcia
2014-04-30 19:40 ` Sebastian Hesselbarth [this message]
2014-05-02 20:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536151C9.4090802@gmail.com \
--to=sebastian.hesselbarth@gmail$(echo .)com \
--cc=alior@marvell$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ezequiel.garcia@free-electrons$(echo .)com \
--cc=gregory.clement@free-electrons$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tawfik@marvell$(echo .)com \
--cc=thomas.petazzoni@free-electrons$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox