Subject: Re: [PATCH] net: filter: add insn for loading internal transport header offset

From: Daniel Borkmann <[email-masked]>
Date: Thu, 01 May 2014 12:55:23 +0200

On 05/01/2014 12:53 PM, Daniel Borkmann wrote:
> [ Chema, please also keep me in cc if possible. ]
>
> On 04/30/2014 08:29 PM, Chema Gonzalez wrote:
>> Patch adds an ANC_TRA_OFFSET insn that loads the internal transport
>> header of a packet ("internal" meaning after decapsulation by the
>> flow dissector).
>>
>> Signed-off-by: Chema Gonzalez <[email-masked]>
>
> Looks good to me. For casting pointers as Dave noted recently, please
> use 'unsigned long'. This needs to be fixed in other places as well.

Ohh, and please in future include net or net-next into your subject line.

> Other than that, you can add my:
>
> Acked-by: Daniel Borkmann <[email-masked]>