From: Grygorii Strashko <grygorii.strashko@ti•com>
To: Arnd Bergmann <arnd@arndb•de>, <linux-arm-kernel@lists•infradead.org>
Cc: <linux-kernel@vger•kernel.org>,
Florian Fainelli <f.fainelli@gmail•com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>,
"Lad, Prabhakar" <prabhakar.csengg@gmail•com>,
"David S. Miller" <davem@davemloft•net>, <netdev@vger•kernel.org>
Subject: Re: [PATCH] mdio_bus: fix devm_mdiobus_alloc_size export
Date: Thu, 8 May 2014 20:01:47 +0300 [thread overview]
Message-ID: <536BB87B.5050808@ti.com> (raw)
In-Reply-To: <1399560433-1402630-2-git-send-email-arnd@arndb.de>
Hi Arnd,
On 05/08/2014 05:46 PM, Arnd Bergmann wrote:
> commit 6d48f44b7b2 "mdio_bus: implement devm_mdiobus_alloc/devm_mdiobus_free"
> introduced a new function devm_mdiobus_alloc_size() but added an export
> for a different function devm_mdiobus_alloc(), which was obviously
> a simple mistake that leads to build error whenever this function is
> used from a loadable module:
>
> ERROR: "devm_mdiobus_alloc_size" [drivers/net/ethernet/ti/davinci_mdio.ko] undefined!
Sorry for that, and thanks a lot for the fix.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb•de>
> Cc: Grygorii Strashko <grygorii.strashko@ti•com>
> Cc: Florian Fainelli <f.fainelli@gmail•com>
> Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
> Cc: Lad, Prabhakar <prabhakar.csengg@gmail•com>
> Cc: David S. Miller <davem@davemloft•net>
> Cc: netdev@vger•kernel.org
> ---
> drivers/net/phy/mdio_bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
> index 68a9a38..a628496 100644
> --- a/drivers/net/phy/mdio_bus.c
> +++ b/drivers/net/phy/mdio_bus.c
> @@ -117,7 +117,7 @@ struct mii_bus *devm_mdiobus_alloc_size(struct device *dev, int sizeof_priv)
>
> return bus;
> }
> -EXPORT_SYMBOL_GPL(devm_mdiobus_alloc);
> +EXPORT_SYMBOL_GPL(devm_mdiobus_alloc_size);
>
> /**
> * devm_mdiobus_free - Resource-managed mdiobus_free()
>
Regards,
-grygorii
next prev parent reply other threads:[~2014-05-08 17:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 14:46 [PATCH 00/22] Random ARM randconfig fixes in drivers Arnd Bergmann
2014-05-08 14:46 ` [PATCH] mdio_bus: fix devm_mdiobus_alloc_size export Arnd Bergmann
2014-05-08 17:01 ` Grygorii Strashko [this message]
2014-05-09 7:06 ` Prabhakar Lad
2014-05-09 20:39 ` David Miller
[not found] ` <1399560433-1402630-1-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>
2014-05-08 16:41 ` [PATCH 00/22] Random ARM randconfig fixes in drivers Guenter Roeck
2014-05-09 11:48 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536BB87B.5050808@ti.com \
--to=grygorii.strashko@ti$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=prabhakar.csengg@gmail$(echo .)com \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox