Subject: Re: [PATCH 1/3] net: of_mdio: factor out code to parse a phy's 'reg' property

From: Sergei Shtylyov <[email-masked]>
Date: Sun, 11 May 2014 00:29:02 +0400

Hello.

On 05/10/2014 08:37 PM, Daniel Mack wrote:

> Factor out some logic into of_mdio_parse_addr() so it can be reused
> later.

> Signed-off-by: Daniel Mack <[email-masked]>
> ---
>   drivers/of/of_mdio.c | 37 +++++++++++++++++++++++++------------
>   1 file changed, 25 insertions(+), 12 deletions(-)

> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
> index 9a95831..171f9d5 100644
> --- a/drivers/of/of_mdio.c
> +++ b/drivers/of/of_mdio.c
> @@ -114,6 +114,29 @@ static int of_mdiobus_register_phy(struct mii_bus *mdio, struct device_node *chi
>   	return 0;
>   }
>
> +static int of_mdio_parse_addr(struct device *dev, const struct device_node *np)
> +{
> +	const __be32 *paddr;
> +	u32 addr;
> +	int len;
> +
> +	/* A PHY must have a reg property in the range [0-31] */
> +	paddr = of_get_property(np, "reg", &len);
> +	if (!paddr || len < sizeof(*paddr)) {
> +		dev_err(dev, "%s has invalid PHY address\n", np->full_name);
> +		return -EINVAL;
> +	}
> +
> +	addr = be32_to_cpup(paddr);

    Why not just use of_property_read_u32() instead of the above? At least 
that's a material for a follow-up patch...

> +	if (addr >= PHY_MAX_ADDR) {
> +		dev_err(dev, "%s PHY address %i is too large\n",
> +			np->full_name, addr);
> +		return -EINVAL;
> +	}
> +
> +	return addr;
> +}
> +
>   /**
>    * of_mdiobus_register - Register mii_bus and create PHYs from the device tree
>    * @mdio: pointer to mii_bus structure
[...]

WBR, Sergei