Subject: Re: [PATCH iproute2] fq: don't allow set options to zero

From: Yang Yingliang <[email-masked]>
Date: Mon, 12 May 2014 14:55:06 +0800

On 2014/5/12 14:51, Yang Yingliang wrote:
> On 2014/5/12 13:58, Eric Dumazet wrote:
>> On Mon, 2014-05-12 at 12:18 +0800, Yang Yingliang wrote:
>>> Now options of fair queue can be zero but cannot be (~0U).
>>> Zero is useless, so don't allow set the options to zero.
>>> Also, maxrate cannot be reset to unlimited because it
>>> cannot be (~0U).
>>>
>>> Cc: Eric Dumazet <[email-masked]>
>>> Signed-off-by: Yang Yingliang <[email-masked]>
>>> ---
>>>  tc/q_fq.c | 24 ++++++++++++------------
>>>  1 file changed, 12 insertions(+), 12 deletions(-)
>>
>> No, you are changing behavior for existing scripts.
>>
>> If you really want to fix these cases, you need to do it properly.
>>
> 
> Do you mean allow options set to zero changing the behavior ?
> 
> Regards,
> Yang
> 
My bad, please ignore this mail.

Sorry for the noisy.