From: Yang Yingliang <yangyingliang@huawei•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: <stephen@networkplumber•org>, <netdev@vger•kernel.org>
Subject: Re: [PATCH iproute2 v2] fq: allow options of fair queue set to ~0U
Date: Tue, 13 May 2014 12:10:38 +0800 [thread overview]
Message-ID: <53719B3E.5040706@huawei.com> (raw)
In-Reply-To: <1399950239.7973.38.camel@edumazet-glaptop2.roam.corp.google.com>
On 2014/5/13 11:03, Eric Dumazet wrote:
> On Tue, 2014-05-13 at 10:23 +0800, Yang Yingliang wrote:
>> From: Yang Yingliang <yangyingliang@huawei•com>
>>
>> Some options of fair queue cannot be (~0U). It leads to maxrate
>> cannot be reset to unlimited because it cannot be (~0U).
>>
>> Suggested-by: Eric Dumazet <edumazet@google•com>
>> Signed-off-by: Yang Yingliang <yangyingliang@huawei•com>
>> ---
>> tc/q_fq.c | 36 ++++++++++++++++++++++++------------
>> 1 file changed, 24 insertions(+), 12 deletions(-)
>>
>> diff --git a/tc/q_fq.c b/tc/q_fq.c
>> index c1f658e..6a493a5 100644
>> --- a/tc/q_fq.c
>> +++ b/tc/q_fq.c
>> @@ -71,13 +71,19 @@ static unsigned int ilog2(unsigned int val)
>> static int fq_parse_opt(struct qdisc_util *qu, int argc, char **argv,
>> struct nlmsghdr *n)
>> {
>> - unsigned int plimit = ~0U;
>> - unsigned int flow_plimit = ~0U;
>> - unsigned int quantum = ~0U;
>> - unsigned int initial_quantum = ~0U;
>> + unsigned int plimit;
>> + unsigned int flow_plimit;
>> + unsigned int quantum;
>> + unsigned int initial_quantum;
>> unsigned int buckets = 0;
>> - unsigned int maxrate = ~0U;
>> - unsigned int defrate = ~0U;
>> + unsigned int maxrate;
>> + unsigned int defrate;
>> + int set_plimit = 0;
>> + int set_flow_plimit = 0;
>> + int set_quantum = 0;
>> + int set_initial_quantum = 0;
>> + int set_maxrate = 0;
>> + int set_defrate = 0;
>> int pacing = -1;
>> struct rtattr *tail;
>>
>> @@ -88,12 +94,14 @@ static int fq_parse_opt(struct qdisc_util *qu, int argc, char **argv,
>> fprintf(stderr, "Illegal \"limit\"\n");
>> return -1;
>> }
>> + set_plimit = 1;
>> } else if (strcmp(*argv, "flow_limit") == 0) {
>> NEXT_ARG();
>> if (get_unsigned(&flow_plimit, *argv, 0)) {
>> fprintf(stderr, "Illegal \"flow_limit\"\n");
>> return -1;
>> }
>> + set_flow_plimit = 0;
>
>
> = 1; ?
>
Yes, thanks!
next prev parent reply other threads:[~2014-05-13 4:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 4:18 [PATCH iproute2] fq: don't allow set options to zero Yang Yingliang
2014-05-12 5:58 ` Eric Dumazet
2014-05-12 6:51 ` Yang Yingliang
2014-05-12 6:55 ` Yang Yingliang
2014-05-12 6:59 ` Yang Yingliang
2014-05-12 15:23 ` Eric Dumazet
2014-05-13 2:23 ` [PATCH iproute2 v2] fq: allow options of fair queue set to ~0U Yang Yingliang
2014-05-13 3:03 ` Eric Dumazet
2014-05-13 4:10 ` Yang Yingliang [this message]
2014-05-13 4:20 ` [PATCH iproute2 v3] " Yang Yingliang
2014-05-29 0:09 ` Stephen Hemminger
2014-05-29 2:43 ` Yang Yingliang
2014-05-29 4:04 ` [PATCH iproute2 v4] " Yang Yingliang
2014-06-09 19:43 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53719B3E.5040706@huawei.com \
--to=yangyingliang@huawei$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox