From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Vlad Yasevich <vyasevic@redhat•com>, netdev@vger•kernel.org
Cc: bridge@lists•linux-foundation.org, shemminger@vyatta•com,
mst@redhat•com, john.r.fastabend@intel•com, jhs@mojatatu•com
Subject: Re: [PATCH net-next 5/8] bridge: Add addresses from static fdbs to non-promisc ports
Date: Thu, 15 May 2014 00:44:51 +0400 [thread overview]
Message-ID: <5373D5C3.60807@cogentembedded.com> (raw)
In-Reply-To: <1400080168-16625-6-git-send-email-vyasevic@redhat.com>
On 05/14/2014 07:09 PM, Vlad Yasevich wrote:
> When a static fdb entry is created, add the mac address
> from this fdb entry to any ports that are currently running
> in non-promiscuous mode. These ports need this data so that
> they can receive traffic destined to these addresses.
> By default ports start in promiscuous mode, so this feature
> is disabled.
> Signed-off-by: Vlad Yasevich <vyasevic@redhat•com>
> ---
> net/bridge/br_fdb.c | 76 ++++++++++++++++++++++++++++++++++++++++++++++++-----
> 1 file changed, 70 insertions(+), 6 deletions(-)
> diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
> index 9759b61..958b68a 100644
> --- a/net/bridge/br_fdb.c
> +++ b/net/bridge/br_fdb.c
> @@ -85,8 +85,58 @@ static void fdb_rcu_free(struct rcu_head *head)
> kmem_cache_free(br_fdb_cache, ent);
> }
>
> +/* When a static FDB entry is added, the mac address from the entry is
> + * added to the bridge private HW address list and all required ports
> + * are then updated with the new information.
> + * Called under RTNL.
> + */
> +static void fdb_add_hw(struct net_bridge *br, const unsigned char *addr)
> +{
> + int err;
> + struct net_bridge_port *p, *tmp = NULL;
Initializer doesn't seem to be needed.
[...]
WBR, Sergei
next prev parent reply other threads:[~2014-05-14 20:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 15:09 [PATCH net-next 0/8] Non-promisc bidge ports support Vlad Yasevich
2014-05-14 15:09 ` [PATCH net-next 1/8] bridge: Turn flag change macro into a function Vlad Yasevich
2014-05-14 15:09 ` [PATCH net-next 2/8] bridge: Keep track of ports capable of automatic discovery Vlad Yasevich
2014-05-14 15:40 ` Stephen Hemminger
2014-05-14 15:42 ` Stephen Hemminger
2014-05-15 16:04 ` Vlad Yasevich
2014-05-14 15:09 ` [PATCH net-next 3/8] bridge: Add functionality to sync static fdb entries to hw Vlad Yasevich
2014-05-14 20:47 ` Sergei Shtylyov
2014-05-14 15:09 ` [PATCH net-next 4/8] bridge: Introduce BR_PROMISC flag Vlad Yasevich
2014-05-14 15:09 ` [PATCH net-next 5/8] bridge: Add addresses from static fdbs to non-promisc ports Vlad Yasevich
2014-05-14 20:44 ` Sergei Shtylyov [this message]
2014-05-14 15:09 ` [PATCH net-next 6/8] bridge: Automatically manage port promiscuous mode Vlad Yasevich
2014-05-14 15:09 ` [PATCH net-next 7/8] bridge: Correctly manage promiscuity when user requested it Vlad Yasevich
2014-05-14 15:09 ` [PATCH net-next 8/8] bridge: Automatically manage promisc mode when vlan filtering is on Vlad Yasevich
2014-05-14 20:41 ` Sergei Shtylyov
2014-05-14 15:21 ` [PATCH net-next 0/8] Non-promisc bidge ports support Michael S. Tsirkin
2014-05-14 19:29 ` David Miller
2014-05-15 16:09 ` Vlad Yasevich
2014-05-15 12:55 ` Toshiaki Makita
2014-05-15 13:02 ` Toshiaki Makita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5373D5C3.60807@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=jhs@mojatatu$(echo .)com \
--cc=john.r.fastabend@intel$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@vyatta$(echo .)com \
--cc=vyasevic@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox