public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Duan Jiong <duanj.fnst@cn•fujitsu.com>
To: David Miller <davem@davemloft•net>
Cc: <kaber@trash•net>, <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next] ip_tunnel: don't add tunnel twice
Date: Fri, 16 May 2014 13:06:47 +0800	[thread overview]
Message-ID: <53759CE7.8000207@cn.fujitsu.com> (raw)
In-Reply-To: <20140515.231051.1178432224326720292.davem@davemloft.net>

于 2014年05月16日 11:10, David Miller 写道:
> From: Duan Jiong <duanj.fnst@cn•fujitsu.com>
> Date: Thu, 15 May 2014 13:07:02 +0800
> 
>>
>> When using command "ip tunnel add" to add a tunnel, the tunnel will be added twice,
>> through ip_tunnel_create() and ip_tunnel_update().
>>
>> Because the second is unnecessary, so we can just break after adding tunnel
>> through ip_tunnel_create().
>>
>> Signed-off-by: Duan Jiong <duanj.fnst@cn•fujitsu.com>
> 
> ip_tunnel_update() seems to do some things tha ip_tunnel_create()
> does not.
> 
> For example, setting dev->dev_addr[] and dev->broadcast[] from the
> ipv4 parms if appropriate.
> 
> I think you need to rethink this change.

When registering tunnel link, function register_netdevice() will call 
dev->netdev_ops->ndo_init, actually the virtual function ndo_init will
do some same things  the ip_tunnel_update() does, such as the 
above you mentioned.

So i think you don't need to worry about that.

Thanks,
   Duan
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

next prev parent reply	other threads:[~2014-05-16  5:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-15  5:07 [PATCH net-next] ip_tunnel: don't add tunnel twice Duan Jiong
2014-05-16  3:10 ` David Miller
2014-05-16  5:06   ` Duan Jiong [this message]
2014-05-16 20:58     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53759CE7.8000207@cn.fujitsu.com \
    --to=duanj.fnst@cn$(echo .)fujitsu.com \
    --cc=davem@davemloft$(echo .)net \
    --cc=kaber@trash$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox