From: Amir Vadai <amirv@mellanox•com>
To: Ben Hutchings <ben@decadent•org.uk>
Cc: "David S. Miller" <davem@davemloft•net>, <netdev@vger•kernel.org>,
Yevgeny Petrilin <yevgenyp@mellanox•com>,
Or Gerlitz <ogerlitz@mellanox•com>,
Carol Soto <clsoto@linux•vnet.ibm.com>
Subject: Re: [PATCH net-next 1/2] net/mlx4_core: Deprecate use_prio module parameter
Date: Tue, 27 May 2014 11:08:38 +0300 [thread overview]
Message-ID: <53844806.6030808@mellanox.com> (raw)
In-Reply-To: <1401132152.27743.2.camel@deadeye.wl.decadent.org.uk>
On 5/26/2014 10:22 PM, Ben Hutchings wrote:
> On Mon, 2014-05-19 at 11:37 +0300, Amir Vadai wrote:
>> It was used for steering by user priority for A0 steering. A0 mode is
>> not supported anymore. Printing a message and ignoring the parameter.
>>
>> CC: Carol Soto <clsoto@linux•vnet.ibm.com>
>> Signed-off-by: Amir Vadai <amirv@mellanox•com>
>> ---
>> drivers/net/ethernet/mellanox/mlx4/main.c | 8 ++++----
>> include/linux/mlx4/device.h | 1 -
>> 2 files changed, 4 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
>> index a56f601..08ff5dd 100644
>> --- a/drivers/net/ethernet/mellanox/mlx4/main.c
>> +++ b/drivers/net/ethernet/mellanox/mlx4/main.c
>> @@ -132,8 +132,7 @@ MODULE_PARM_DESC(log_num_vlan, "Log2 max number of VLANs per ETH port (0-7)");
>>
>> static bool use_prio;
>> module_param_named(use_prio, use_prio, bool, 0444);
>
> Perhaps the sysfs permissions should be set to 0 (i.e. not visible in
> sysfs)?
>
Good idea - since the series already applied, will send another patch.
[...]
>> + if (use_prio != 0)
>> + pr_warn("mlx4_core: use_prio - obsolete module param, ignored\n");
>
> You spell it pr_warning() in the adjacent logging statements.
Patch 2/2 "net/mlx4_core: Replace pr_warning() with pr_warn()" in this
patch series will take care to the other pr_warning's
Thanks,
Amir
>
> Ben.
>
next prev parent reply other threads:[~2014-05-27 8:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 8:37 [PATCH net-next 0/2] net/mlx4_core: Deprecate module parameter use_prio Amir Vadai
2014-05-19 8:37 ` [PATCH net-next 1/2] net/mlx4_core: Deprecate use_prio module parameter Amir Vadai
2014-05-21 19:49 ` David Miller
2014-05-22 12:59 ` Amir Vadai
2014-05-26 19:22 ` Ben Hutchings
2014-05-27 8:08 ` Amir Vadai [this message]
2014-05-19 8:37 ` [PATCH net-next 2/2] net/mlx4_core: Replace pr_warning() with pr_warn() Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53844806.6030808@mellanox.com \
--to=amirv@mellanox$(echo .)com \
--cc=ben@decadent$(echo .)org.uk \
--cc=clsoto@linux$(echo .)vnet.ibm.com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=yevgenyp@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox