Subject: Re: [PATCH 7/9] tlan: Make autonegotiation faster

From: Sergei Shtylyov <[email-masked]>
Date: Wed, 28 May 2014 18:11:06 +0400

Hello.

On 05/28/2014 01:38 AM, Ondrej Zary wrote:

> Reduce the autonegotiation poll interval from 8 seconds to 2.
> This greatly reduces the time needed to detect link presence,
> especially on Olicom cards at 10 Mbps (two autonegoatiations required).

> Signed-off-by: Ondrej Zary <[email-masked]>
> ---
>   drivers/net/ethernet/ti/tlan.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c
> index 628a779..007c2fe 100644
> --- a/drivers/net/ethernet/ti/tlan.c
> +++ b/drivers/net/ethernet/ti/tlan.c
> @@ -2699,7 +2699,7 @@ static void tlan_phy_finish_auto_neg(struct net_device *dev)
>   		/* Wait for 8 sec to give the process
>   		 * more time.  Perhaps we should fail after a while.
>   		 */
> -		tlan_set_timer(dev, (8*HZ), TLAN_TIMER_PHY_FINISH_AN);
> +		tlan_set_timer(dev, (2*HZ), TLAN_TIMER_PHY_FINISH_AN);

    The inner () not needed but space around * wouldn't hurt.

>   		return;
>   	}

WBR, Sergei