From: Ding Tianhong <dingtianhong@huawei•com>
To: Vlad Yasevich <vyasevich@gmail•com>, <kaber@trash•net>,
<davem@davemloft•net>
Cc: <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next 0/2] macvlan: fix the problem when mac address changes for passthru mode
Date: Thu, 29 May 2014 11:29:58 +0800 [thread overview]
Message-ID: <5386A9B6.40505@huawei.com> (raw)
In-Reply-To: <53860DA5.8090407@gmail.com>
On 2014/5/29 0:24, Vlad Yasevich wrote:
> On 05/26/2014 08:10 AM, Ding Tianhong wrote:
>> Ding Tianhong (2):
>> macvlan: don't change macvlan address alone for passthru mode
>> macvlan: propagate lowerdev mac address changes for passthru mode
>>
>> drivers/net/macvlan.c | 40 +++++++++++++++++++++++++++++++---------
>> 1 file changed, 31 insertions(+), 9 deletions(-)
>>
>
> This ends up working kind-of backwards... A user now has to know
> that passthru macvlans he has to change the lower-level mac, but
> for all others, changing the macvlan mac is ok and will work...
Yes, more rules for it, but I think a user should know it.
>
> This also will not work if the passthru macvlan is stacked on
> something other the hw (for example: a vlan).
passthru is a special mode, will not be used for every situation.
>
> Why not simply propagate the mac address change of the passhtru macvlan
> down to the real device?
>
Yes, I am considering this problem for a long time, I'm not sure the macvlan should propagate the mac address change to
the real device, but your suggestion looks good to me, thanks for your advise, I will think about it and fix it.
Ding
> Thanks
> -vlad
>
>
prev parent reply other threads:[~2014-05-29 3:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 12:10 [PATCH net-next 0/2] macvlan: fix the problem when mac address changes for passthru mode Ding Tianhong
2014-05-26 12:10 ` [PATCH net-next 1/2] macvlan: don't change macvlan address alone " Ding Tianhong
2014-05-26 12:10 ` [PATCH net-next 2/2] macvlan: propagate lowerdev mac address changes " Ding Tianhong
2014-05-28 16:24 ` [PATCH net-next 0/2] macvlan: fix the problem when " Vlad Yasevich
2014-05-29 3:29 ` Ding Tianhong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5386A9B6.40505@huawei.com \
--to=dingtianhong@huawei$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vyasevich@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox