From: Jamal Hadi Salim <jhs@mojatatu•com>
To: Roopa Prabhu <roopa@cumulusnetworks•com>,
Stephen Hemminger <stephen@networkplumber•org>
Cc: Vlad Yasevich <vyasevich@gmail•com>,
davem@davemloft•net, netdev@vger•kernel.org,
wkok@cumulusnetworks•com, sfeldma@cumulusnetworks•com,
shm@cumulusnetworks•com
Subject: Re: [PATCH iproute2] bridge: Add master device name to bridge fdb show
Date: Sat, 31 May 2014 07:10:31 -0400 [thread overview]
Message-ID: <5389B8A7.8030301@mojatatu.com> (raw)
In-Reply-To: <53895A48.2040203@cumulusnetworks.com>
On 05/31/14 00:27, Roopa Prabhu wrote:
> On 5/30/14, 7:36 AM, Stephen Hemminger wrote:
> but set also uses 'master' ..and the bridge is referenced using 'master'
> in almost all commands
> #ip link set dev brport master brdev
>
> so, using 'bridge' and 'master' interchangeably seems a bit confusing.
>
> But, if the preference is 'bridge' i will resubmit this patch with
> 'bridge' shortly.
Sorry - I guess until i looked at the code again last few minutes,
it had skipped my mind that this interface is also used for vxlan. So
master now seems to make more sense ;->
Vlad, you may get your wish - it seems if i am going to have to set
the bridge device as a filter I will have no choice but to use an
ifm since it is size different from ndm. Which is not a big deal
until i attach an attribute - which breaks old iproute2 out in
the wild already. I have to say i am not liking this (because i was
hoping to add other filters in the future, example vlan)
but dont see a way out.
So the only way this would work is to use the original ifm as
the header.
cheers,
jamal
prev parent reply other threads:[~2014-05-31 11:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 5:40 [PATCH iproute2] bridge: Add master device name to bridge fdb show roopa
2014-05-28 20:00 ` Vlad Yasevich
2014-05-29 1:53 ` Roopa Prabhu
2014-05-30 14:36 ` Stephen Hemminger
2014-05-31 4:27 ` Roopa Prabhu
2014-05-31 11:10 ` Jamal Hadi Salim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5389B8A7.8030301@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=roopa@cumulusnetworks$(echo .)com \
--cc=sfeldma@cumulusnetworks$(echo .)com \
--cc=shm@cumulusnetworks$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=vyasevich@gmail$(echo .)com \
--cc=wkok@cumulusnetworks$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox