Subject: Re: [PULL 2/2] vhost: replace rcu with mutex

From: Paolo Bonzini <[email-masked]>
Date: Tue, 03 Jun 2014 14:48:34 +0200

Il 02/06/2014 23:58, Eric Dumazet ha scritto:
> This looks dubious
>
> What about using kfree_rcu() instead ?

It would lead to unbound allocation from userspace.

> translate_desc() still uses rcu_read_lock(), its not clear if the mutex
> is really held.

Yes, vhost_get_vq_desc must be called with the vq mutex held.

The rcu_read_lock/unlock in translate_desc is unnecessary.

Paolo