Subject: Re: [PATCH] gianfar: Call netif_carrier_off() prior to registration

From: Florian Fainelli <[email-masked]>
Date: Tue, 03 Jun 2014 19:42:04 -0700

Le 03/06/2014 19:05, David Miller a écrit :
> From: Florian Fainelli <[email-masked]>
> Date: Tue, 3 Jun 2014 16:04:49 -0700
>
>> 2014-06-03 15:55 GMT-07:00 Fabio Estevam <[email-masked]>:
>>> From: Fabio Estevam <[email-masked]>
>>>
>>> Quoting David Miller:
>>> "At the moment you call register_netdev() the device is visible, notifications
>>> are sent to userspace, and userland tools can try to bring the interface up
>>> and see the incorrect link state, before you do the netif_carrier_off().
>>>
>>> Said another way, between the register_netdev() and netif_carrier_off() call,
>>> userspace can see the device in an inconsistent state."
>>>
>>> So call netif_carrier_off() prior to register_netdev().
>>
>> Potentially all drivers implementing libphy correctly should be fixed
>> to start with a carrier off until the phy library has determined
>> otherwise.
>
> Are you saying we should hold off on this gianfar patch?

Not at all, I think this patch is fine. If Fabio wants/can audit the 
other Freescale drivers I think this should be beneficial.
--
Florian