Subject: Re: [PATCH] netfilter: nf_conntrack: fix checkpatch errors

From: Luca Ellero <[email-masked]>
Date: Wed, 04 Jun 2014 08:49:46 +0200

Il 03/06/2014 22:48, Patrick McHardy ha scritto:
> On Tue, Jun 03, 2014 at 04:45:02PM +0200, Luca Ellero wrote:
>> Add parenthesis around complex macros
>>
>> Signed-off-by: Luca Ellero <[email-masked]>
>> ---
>>   net/netfilter/nf_conntrack_pptp.c       |    6 +++---
>>   net/netfilter/nf_conntrack_proto_sctp.c |    8 ++++----
>>   net/netfilter/nf_conntrack_proto_tcp.c  |    8 ++++----
>>   3 files changed, 11 insertions(+), 11 deletions(-)
>>
>> diff --git a/net/netfilter/nf_conntrack_pptp.c b/net/netfilter/nf_conntrack_pptp.c
>> index 825c3e3..a505263 100644
>> --- a/net/netfilter/nf_conntrack_pptp.c
>> +++ b/net/netfilter/nf_conntrack_pptp.c
>> @@ -92,9 +92,9 @@ const char *const pptp_msg_name[] = {
>>   EXPORT_SYMBOL(pptp_msg_name);
>>   #endif
>>
>> -#define SECS *HZ
>> -#define MINS * 60 SECS
>> -#define HOURS * 60 MINS
>> +#define SECS  (*HZ)
>> +#define MINS  (*60 SECS)
>> +#define HOURS (*60 MINS)
>
> Don't send patches that you obviously didn't even compile test.
>

beg your pardon, my bad... send it by mistake
Sorry for the noise
Regards
Luca