From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: davem@davemloft•net, Shannon Nelson <shannon.nelson@intel•com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel•com>,
netdev@vger•kernel.org, gospo@redhat•com, sassmann@redhat•com
Subject: Re: [net-next 01/13] i40e: add checks for AQ error status bits
Date: Mon, 09 Jun 2014 17:21:05 +0400 [thread overview]
Message-ID: <5395B4C1.7070004@cogentembedded.com> (raw)
In-Reply-To: <1402303758-1429-2-git-send-email-jeffrey.t.kirsher@intel.com>
Hello.
On 06/09/2014 12:49 PM, Jeff Kirsher wrote:
> From: Shannon Nelson <shannon.nelson@intel•com>
> Check for error status bits on the AdminQ event queue and announce them
> if seen. If the Firmware sets these bits, it will trigger an AdminQ
> interrupt to get the driver's attention to process the ARQ, which will
> likely be enough to clear the actual issue.
> Signed-off-by: Shannon Nelson <shannon.nelson@intel•com>
> Change-ID: I009e0ebc8be764e40e193b29aed2863f43eb5cb0
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel•com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_main.c | 36 +++++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
> index 8c16e18..ab0b6e1 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> @@ -5132,11 +5132,47 @@ static void i40e_clean_adminq_subtask(struct i40e_pf *pf)
> u16 pending, i = 0;
> i40e_status ret;
> u16 opcode;
> + u32 oldval;
> u32 val;
>
> if (!test_bit(__I40E_ADMINQ_EVENT_PENDING, &pf->state))
> return;
>
> + /* check for error indications */
> + val = rd32(&pf->hw, pf->hw.aq.arq.len);
> + oldval = val;
> + if (val & I40E_PF_ARQLEN_ARQVFE_MASK) {
> + dev_info(&pf->pdev->dev, "ARQ VF Error detected\n");
Hm, why not dev_err() here and below?
> + val &= ~I40E_PF_ARQLEN_ARQVFE_MASK;
> + }
> + if (val & I40E_PF_ARQLEN_ARQOVFL_MASK) {
> + dev_info(&pf->pdev->dev, "ARQ Overflow Error detected\n");
> + val &= ~I40E_PF_ARQLEN_ARQOVFL_MASK;
> + }
> + if (val & I40E_PF_ARQLEN_ARQCRIT_MASK) {
> + dev_info(&pf->pdev->dev, "ARQ Critical Error detected\n");
> + val &= ~I40E_PF_ARQLEN_ARQCRIT_MASK;
> + }
> + if (oldval != val)
> + wr32(&pf->hw, pf->hw.aq.arq.len, val);
> +
> + val = rd32(&pf->hw, pf->hw.aq.asq.len);
> + oldval = val;
> + if (val & I40E_PF_ATQLEN_ATQVFE_MASK) {
> + dev_info(&pf->pdev->dev, "ASQ VF Error detected\n");
> + val &= ~I40E_PF_ATQLEN_ATQVFE_MASK;
> + }
> + if (val & I40E_PF_ATQLEN_ATQOVFL_MASK) {
> + dev_info(&pf->pdev->dev, "ASQ Overflow Error detected\n");
> + val &= ~I40E_PF_ATQLEN_ATQOVFL_MASK;
> + }
> + if (val & I40E_PF_ATQLEN_ATQCRIT_MASK) {
> + dev_info(&pf->pdev->dev, "ASQ Critical Error detected\n");
> + val &= ~I40E_PF_ATQLEN_ATQCRIT_MASK;
> + }
> + if (oldval != val)
> + wr32(&pf->hw, pf->hw.aq.asq.len, val);
> +
WBR, Sergei
next prev parent reply other threads:[~2014-06-09 13:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 8:49 [net-next 00/13][pull request] Intel Wired LAN Driver Updates 2014-06-09 Jeff Kirsher
2014-06-09 8:49 ` [net-next 01/13] i40e: add checks for AQ error status bits Jeff Kirsher
2014-06-09 13:21 ` Sergei Shtylyov [this message]
2014-06-09 20:35 ` Jeff Kirsher
2014-06-09 21:02 ` Joe Perches
2014-06-09 21:10 ` Jeff Kirsher
2014-06-09 21:18 ` Joe Perches
2014-06-09 8:49 ` [net-next 02/13] i40evf: Fix function header Jeff Kirsher
2014-06-09 8:49 ` [net-next 03/13] i40e: allow for more VSIs Jeff Kirsher
2014-06-09 8:49 ` [net-next 04/13] i40e: remove unused variable and memory allocation Jeff Kirsher
2014-06-09 8:49 ` [net-next 05/13] i40e: don't complain about removing non-existent addresses Jeff Kirsher
2014-06-09 8:49 ` [net-next 06/13] i40e: implement anti-spoofing for VFs Jeff Kirsher
2014-06-09 19:49 ` Or Gerlitz
2014-06-11 12:13 ` Jeff Kirsher
2014-06-11 12:43 ` Or Gerlitz
2014-06-11 14:37 ` Jeff Kirsher
2014-06-09 8:49 ` [net-next 07/13] i40e: Changes to Interrupt distribution policy Jeff Kirsher
2014-06-09 8:49 ` [net-next 08/13] i40e: keep SR-IOV enabled in the case that RSS, VMDQ, FD_SB and DCB are disabled Jeff Kirsher
2014-06-09 8:49 ` [net-next 09/13] i40e/i40evf: add PPRS bit to error bits and fix bug in Rx checksum Jeff Kirsher
2014-06-09 8:49 ` [net-next 10/13] i40e: Do not fall back to one queue model if the only feature enabled is ATR Jeff Kirsher
2014-06-09 8:49 ` [net-next 11/13] i40e: Delete stale MAC filters after change Jeff Kirsher
2014-06-09 8:49 ` [net-next 12/13] i40e: Allow RSS table entry range and GPS to be any number, not necessarily power of 2 Jeff Kirsher
2014-06-09 8:49 ` [net-next 13/13] i40e/i40evf: bump version to 0.4.7 for i40e and 0.9.31 for i40evf Jeff Kirsher
2014-06-11 3:26 ` [net-next 00/13][pull request] Intel Wired LAN Driver Updates 2014-06-09 David Miller
2014-06-11 10:16 ` Jeff Kirsher
2014-06-11 10:42 ` Or Gerlitz
2014-06-11 12:05 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5395B4C1.7070004@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gospo@redhat$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sassmann@redhat$(echo .)com \
--cc=shannon.nelson@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox