From: Jongsung Kim <neidhard.kim@lge•com>
To: "Nicolas Ferre" <nicolas.ferre@atmel•com>,
"Sören Brinkmann" <soren.brinkmann@xilinx•com>
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
"David S. Miller" <davem@davemloft•net>,
Hayun Hwang <hwang.hayun@lge•com>,
Youngkyu Choi <youngkyu7.choi@lge•com>,
Cyrille Pitchen <cyrille.pitchen@atmel•com>
Subject: Re: [PATCH] net/cadence/macb: clear interrupts simply and correctly
Date: Wed, 18 Jun 2014 17:44:31 +0900 [thread overview]
Message-ID: <53A1516F.7010201@lge.com> (raw)
In-Reply-To: <539FF43E.2020002@atmel.com>
On 06/17/2014 04:54 PM, Nicolas Ferre wrote:
Hi Nicolas,
> On 17/06/2014 05:39, Jongsung Kim :
>> On 06/17/2014 06:28 AM, Sören Brinkmann wrote:
>>> Shouldn't it be sufficient to replace 'MACB_BIT(RCOMP) with 'MACB_RX_INT_FLAGS'
>>> to clear all the RX IRQ flags.
>>
>> I'm afraid not.
>>
>> You know, this driver initially targeted only GEMs configured with "gem_irq_clear_read."
>> For this implementation of GEM, the ISR is automatically cleared by reading. The driver
>> was designed to operate with the value read from ISR, not with the ISR itself.
>>
>> However, there are other GEMs configured without "gem_irq_clear_read," people like you
>> and I working with. To support them, they insert similar codes conditionally clearing
>> the ISR here and there. Now they are found at 6 places. Not enough yet. Do you want to
>> insert another at the end of macb_reset_hw..? Maybe not.
>
> Can't we separate a bit more the implementations of "clear on read" and
> "clear on write" so that we do not spread the tests that you are talking
> about all over the place and slower the driver's hot paths?
I see. I'll revise my patch. Thank you for your advice.
Regards,
Jongsung
prev parent reply other threads:[~2014-06-18 8:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 8:50 [PATCH] net/cadence/macb: clear interrupts simply and correctly Jongsung Kim
2014-06-12 15:44 ` Sören Brinkmann
2014-06-16 5:00 ` Jongsung Kim
2014-06-16 14:56 ` Sören Brinkmann
2014-06-17 2:38 ` Jongsung Kim
2014-06-17 3:50 ` Sören Brinkmann
2014-06-17 4:42 ` Jongsung Kim
2014-06-16 21:28 ` Sören Brinkmann
2014-06-17 3:39 ` Jongsung Kim
2014-06-17 7:54 ` Nicolas Ferre
2014-06-18 8:44 ` Jongsung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A1516F.7010201@lge.com \
--to=neidhard.kim@lge$(echo .)com \
--cc=cyrille.pitchen@atmel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=hwang.hayun@lge$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.ferre@atmel$(echo .)com \
--cc=soren.brinkmann@xilinx$(echo .)com \
--cc=youngkyu7.choi@lge$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox