public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: chenweilong <chenweilong@huawei•com>
To: David Miller <davem@davemloft•net>
Cc: netdev <netdev@vger•kernel.org>
Subject: [PATCH 3.4-stable] ipv6: reallocate addrconf router for ipv6 address when lo, device up
Date: Thu, 19 Jun 2014 08:50:33 +0800	[thread overview]
Message-ID: <53A233D9.8070202@huawei.com> (raw)

Hi David,

Please queue this for 3.4 stable kernel.

It fix the bug 67951 on bugzilla
https://bugzilla.kernel.org/show_bug.cgi?id=67951

The patch can't be applied directly, as it' used the function introduced
by "commit 94e187c0" ip6_rt_put(), that patch can't be applied directly
either. So I had to write this one.

====================

From: Gao feng <gaofeng@cn•fujitsu.com>

commit 33d99113b1102c2d2f8603b9ba72d89d915c13f5 upstream.

This commit don't have a stable tag, but it fix the bug
no reply after loopback down-up.It's very worthy to be
applied to stable 3.4 kernels.

The bug is 67951 on bugzilla
https://bugzilla.kernel.org/show_bug.cgi?id=67951


CC: Sabrina Dubroca <sd@queasysnail•net>
CC: Hannes Frederic Sowa <hannes@stressinduktion•org>
Reported-by: Weilong Chen <chenweilong@huawei•com>
Signed-off-by: Weilong Chen <chenweilong@huawei•com>
Signed-off-by: Gao feng <gaofeng@cn•fujitsu.com>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion•org>
Signed-off-by: David S. Miller <davem@davemloft•net>
[weilong: s/ip6_rt_put/dst_release]
Signed-off-by: Chen Weilong <chenweilong@huawei•com>
Signed-off-by: Li Zefan <lizefan@huawei•com>
---
 net/ipv6/addrconf.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index abfa007..25399bf 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -2435,8 +2435,18 @@ static void init_loopback(struct net_device *dev)
 			if (sp_ifa->flags & (IFA_F_DADFAILED | IFA_F_TENTATIVE))
 				continue;

-			if (sp_ifa->rt)
-				continue;
+			if (sp_ifa->rt) {
+				/* This dst has been added to garbage list when
+				 * lo device down, release this obsolete dst and
+				 * reallocate a new router for ifa.
+				 */
+				if (sp_ifa->rt->dst.obsolete > 0) {
+					dst_release(sp_ifa->rt);
+					sp_ifa->rt = NULL;
+				} else {
+					continue;
+				}
+			}

 			sp_rt = addrconf_dst_alloc(idev, &sp_ifa->addr, 0);

-- 1.7.12

             reply	other threads:[~2014-06-19  0:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-19  0:50 chenweilong [this message]
2014-07-25  4:08 ` [PATCH 3.4-stable] ipv6: reallocate addrconf router for ipv6 address when lo, device up David Miller
2014-08-06  8:01   ` chenweilong
  -- strict thread matches above, loose matches on Subject: below --
2014-07-09  1:35 chenweilong
2014-06-17 10:23 chenweilong
2014-08-05 18:18 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A233D9.8070202@huawei.com \
    --to=chenweilong@huawei$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox