Subject: Re: [PATCH] of: mdio: fixup of_phy_register_fixed_link parsing of new bindings

From: Sergei Shtylyov <[email-masked]>
Date: Thu, 19 Jun 2014 23:32:32 +0400

Hello.

On 06/19/2014 09:35 PM, Richard Retanubun wrote:

> Fixes commit 3be2a49e5c08 ("of: provide a binding for fixed link PHYs")

> Fix the parsing of the new fixed link dts bindings for duplex,
> pause, and asym_pause by using the correct device node pointer.

> Signed-off-by: Richard Retanubun <[email-masked]>
> ---
>   drivers/of/of_mdio.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)

> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
> index 7700ddc..c389e7b 100644
> --- a/drivers/of/of_mdio.c
> +++ b/drivers/of/of_mdio.c
> @@ -290,11 +290,13 @@ int of_phy_register_fixed_link(struct device_node *np)
>   	fixed_link_node = of_get_child_by_name(np, "fixed-link");
>   	if (fixed_link_node) {
>   		status.link = 1;
> -		status.duplex = of_property_read_bool(np, "full-duplex");
> +		status.duplex = of_property_read_bool(fixed_link_node,
> +					"full-duplex");

    The continuation line should start under 'fixed_link_node', according to 
the networking coding style.

>   		if (of_property_read_u32(fixed_link_node, "speed", &status.speed))
>   			return -EINVAL;
> -		status.pause = of_property_read_bool(np, "pause");
> -		status.asym_pause = of_property_read_bool(np, "asym-pause");
> +		status.pause = of_property_read_bool(fixed_link_node, "pause");
> +		status.asym_pause = of_property_read_bool(fixed_link_node,
> +						"asym-pause");

    Same here...

WBR, Sergei