From: Oliver Hartkopp <socketcan@hartkopp•net>
To: David Miller <davem@davemloft•net>,
duanj.fnst@cn•fujitsu.com, lisovy@gmail•com
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH net-next] net: em_canid: remove useless statements from em_canid_change
Date: Sun, 22 Jun 2014 18:27:34 +0200 [thread overview]
Message-ID: <53A703F6.9090507@hartkopp.net> (raw)
In-Reply-To: <20140621.154036.2087202508923213287.davem@davemloft.net>
This is right for the first set of filters that is ever configured in
em_canid_change().
But what happens in an update case?
Does is turn the cm_old reference to a memory leak then?
Or do we always get a brand new "struct tcf_ematch *m" here??
Regards,
Oliver
On 22.06.2014 00:40, David Miller wrote:
> From: Duan Jiong <duanj.fnst@cn•fujitsu.com>
> Date: Wed, 18 Jun 2014 16:48:39 +0800
>
>> tcf_ematch is allocated by kzalloc in function tcf_em_tree_validate(),
>> so cm_old is always NULL.
>>
>> Signed-off-by: Duan Jiong <duanj.fnst@cn•fujitsu.com>
>
> Applied, thanks.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-06-22 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 8:48 [PATCH net-next] net: em_canid: remove useless statements from em_canid_change Duan Jiong
2014-06-21 22:40 ` David Miller
2014-06-22 16:27 ` Oliver Hartkopp [this message]
2014-06-23 0:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A703F6.9090507@hartkopp.net \
--to=socketcan@hartkopp$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=duanj.fnst@cn$(echo .)fujitsu.com \
--cc=lisovy@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox