From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Vince Bridgers <vbridgers2013@gmail•com>,
f.fainelli@gmail•com, netdev@vger•kernel.org
Subject: Re: [PATCH net v3 2/3] libphy: Add stubs to hook IEEE MMD Register reads and writes
Date: Mon, 23 Jun 2014 16:29:10 +0400 [thread overview]
Message-ID: <53A81D96.3040904@cogentembedded.com> (raw)
In-Reply-To: <1403482910-20821-3-git-send-email-vbridgers2013@gmail.com>
Hello.
On 06/23/2014 04:21 AM, Vince Bridgers wrote:
> The Micrel ksz9021 PHY does not support standard IEEE standard MMD
> extended register access, therefore requires stubs to fail the read
> register method and do nothing for the write register method when
> libphy attempts to read and/or configure Energy Efficient Ethernet
> features in PHYS that do support those features. This problem
> was observed on an Altera Cyclone V SOC development kit that
> uses the Synopsys EMAC and the Micrel ksz9021 PHY. This patch
> was tested on the same board, and Energy Efficient Ethernet is
> now disabled as expected since the Micrel PHY does not support that
> feature.
> Signed-off-by: Vince Bridgers <vbridgers2013@gmail•com>
> ---
> V3: Remove unnecessary returns from void functions.
> V2: Split libphy and Micrel specific changes into 2 patches
> based on review comments
> ---
> drivers/net/phy/micrel.c | 23 ++++++++++++++++++++++-
> 1 file changed, 22 insertions(+), 1 deletion(-)
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index bc7c7d2..daf8bab 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -417,7 +417,26 @@ static int ksz8873mll_read_status(struct phy_device *phydev)
>
> static int ksz8873mll_config_aneg(struct phy_device *phydev)
> {
> - return 0;
Eh? The function returns *int* and you're removing the only *return*
statement?
> +}
WBR, Sergei
next prev parent reply other threads:[~2014-06-23 12:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 0:21 [PATCH net v3 0/3] libphy: Add phy specific function to access mmd Vince Bridgers
2014-06-23 0:21 ` [PATCH net v3 1/3] libphy: Add phy specific function to access mmd phy registers Vince Bridgers
2014-06-23 0:21 ` [PATCH net v3 2/3] libphy: Add stubs to hook IEEE MMD Register reads and writes Vince Bridgers
2014-06-23 12:29 ` Sergei Shtylyov [this message]
2014-06-28 19:47 ` Vince Bridgers
2014-06-23 0:21 ` [PATCH net v3 3/3] Documentation: networking: phy.txt: Update text for indirect MMD access Vince Bridgers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A81D96.3040904@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vbridgers2013@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox