From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Anish Bhatt <anish@chelsio•com>, netdev@vger•kernel.org
Cc: davem@davemloft•net, leedom@chelsio•com, hariprasad@chelsio•com
Subject: Re: [PATCH] cxgb4: Fix endian bug introduced in 76bcb31efc0685574fb123f7aaa92f8a50c14fd9
Date: Tue, 24 Jun 2014 17:55:54 +0400 [thread overview]
Message-ID: <53A9836A.8000900@cogentembedded.com> (raw)
In-Reply-To: <1403569649-22649-2-git-send-email-anish@chelsio.com>
Hello.
On 06/24/2014 04:27 AM, Anish Bhatt wrote:
Please move the "introduced by <SHA1>" part of the subject into the
changelog and add to <SHA1> the summary line of that commit in enclosed in
parens. You can also add:
Fixes: <12-digit SHA1> ("<commit summary>")
before your signoff.
> Signed-off-by: Anish Bhatt <anish@chelsio•com>
> ---
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c
> index 39b4a85..a8b1073 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c
> @@ -488,12 +488,12 @@ static void cxgb4_setpfccfg(struct net_device *dev, int priority, u8 pfccfg)
> pcmd.op_to_portid |= cpu_to_be32(FW_PORT_CMD_APPLY);
>
> pcmd.u.dcb.pfc.type = FW_PORT_DCB_TYPE_PFC;
> - pcmd.u.dcb.pfc.pfcen = cpu_to_be16(pi->dcb.pfcen);
> + pcmd.u.dcb.pfc.pfcen = pi->dcb.pfcen;
>
> if (pfccfg)
> - pcmd.u.dcb.pfc.pfcen |= cpu_to_be16(1 << priority);
> + pcmd.u.dcb.pfc.pfcen |= (1 << priority);
> else
> - pcmd.u.dcb.pfc.pfcen &= cpu_to_be16(~(1 << priority));
> + pcmd.u.dcb.pfc.pfcen &= (~(1 << priority));
Outer () not needed here and above.
WBR, Sergei
next prev parent reply other threads:[~2014-06-24 13:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 0:27 [PATCH net-next ] cxgb4: Fix issues caught by sparse in dcb patchset Anish Bhatt
2014-06-24 0:27 ` [PATCH] cxgb4: Fix endian bug introduced in 76bcb31efc0685574fb123f7aaa92f8a50c14fd9 Anish Bhatt
2014-06-24 13:55 ` Sergei Shtylyov [this message]
2014-06-24 5:26 ` [PATCH net-next ] cxgb4: Fix issues caught by sparse in dcb patchset David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A9836A.8000900@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=anish@chelsio$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=hariprasad@chelsio$(echo .)com \
--cc=leedom@chelsio$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox