Subject: Re: [PATCH 05/17] MIPS: bpf: Return error code if the offset is a negative number

From: Markos Chandras <[email-masked]>
Date: Wed, 25 Jun 2014 09:12:53 +0100

On 06/23/2014 11:09 PM, Alexei Starovoitov wrote:
> On Mon, Jun 23, 2014 at 2:38 AM, Markos Chandras
> <[email-masked]> wrote:
>> Previously, the negative offset was not checked leading to failures
>> due to trying to load data beyond the skb struct boundaries. Until we
>> have proper asm helpers in place, it's best if we return ENOSUPP if K
>> is negative when trying to JIT the filter or 0 during runtime if we
>> do an indirect load where the value of X is unknown during build time.
>>
>> Cc: "David S. Miller" <[email-masked]>
>> Cc: Daniel Borkmann <[email-masked]>
>> Cc: Alexei Starovoitov <[email-masked]>
>> Cc: [email-masked]
>> Signed-off-by: Markos Chandras <[email-masked]>
> 
> Hi Markos,
> 
> thank you for addressing all of my earlier comments.
> Looks like test_bpf was quite useful in finding all of these bugs :)
> For the patches that reached netdev:
> 
> Acked-by: Alexei Starovoitov <[email-masked]>
> 

Thank you for the review and your constructive comments in your previous
emails.

-- 
markos