From: Pavel Emelyanov <xemul@parallels•com>
To: Christoph Paasch <christoph.paasch@uclouvain•be>,
David Miller <davem@davemloft•net>
Cc: <netdev@vger•kernel.org>, Andrew Vagin <avagin@openvz•org>
Subject: Re: [PATCH net] tcp: Fix divide by zero when pushing during tcp-repair
Date: Mon, 30 Jun 2014 17:12:25 +0400 [thread overview]
Message-ID: <53B16239.80402@parallels.com> (raw)
In-Reply-To: <1403972797-15285-1-git-send-email-christoph.paasch@uclouvain.be>
On 06/28/2014 08:26 PM, Christoph Paasch wrote:
> When in repair-mode and TCP_RECV_QUEUE is set, we end up calling
> tcp_push with mss_now being 0. If data is in the send-queue and
> tcp_set_skb_tso_segs gets called, we crash because it will divide by
> mss_now:
>
snip
> Cc: Andrew Vagin <avagin@openvz•org>
> Cc: Pavel Emelyanov <xemul@parallels•com>
> Fixes: ec3423257508 (tcp: fix retransmission in repair mode)
> Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain•be>
Acked-by: Pavel Emelyanov <xemul@parallels•com>
Thanks,
Pavel
next prev parent reply other threads:[~2014-06-30 13:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-28 16:26 [PATCH net] tcp: Fix divide by zero when pushing during tcp-repair Christoph Paasch
2014-06-30 13:05 ` Andrey Wagin
2014-06-30 13:12 ` Pavel Emelyanov [this message]
2014-07-03 1:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B16239.80402@parallels.com \
--to=xemul@parallels$(echo .)com \
--cc=avagin@openvz$(echo .)org \
--cc=christoph.paasch@uclouvain$(echo .)be \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox