From: Stefan Wahren <stefan.wahren@i2se•com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>,
davem@davemloft•net, robh+dt@kernel•org, pawel.moll@arm•com,
mark.rutland@arm•com, ijc+devicetree@hellion•org.uk,
galak@codeaurora•org, f.fainelli@gmail•com,
eric.dumazet@gmail•com, dave.taht@gmail•com
Cc: netdev@vger•kernel.org, devicetree@vger•kernel.org
Subject: Re: [PATCH RFC V2 1/2] Documentation: add Device tree bindings for QCA7000
Date: Wed, 02 Jul 2014 09:01:48 +0200 [thread overview]
Message-ID: <53B3AE5C.6040005@i2se.com> (raw)
In-Reply-To: <53B2F0D1.6070602@cogentembedded.com>
Hello Sergei,
Am 01.07.2014 19:33, schrieb Sergei Shtylyov:
> Hello.
>
> On 07/01/2014 08:36 PM, Stefan Wahren wrote:
>
>> This patch adds the Device tree bindings for the
>> Ethernet over SPI protocol driver of the Qualcomm
>> QCA7000 HomePlug GreenPHY.
>
>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se•com>
>> ---
>> .../devicetree/bindings/net/qca-qca7000-spi.txt | 47
>> ++++++++++++++++++++
>> 1 file changed, 47 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/net/qca-qca7000-spi.txt
>
>> diff --git
>> a/Documentation/devicetree/bindings/net/qca-qca7000-spi.txt
>> b/Documentation/devicetree/bindings/net/qca-qca7000-spi.txt
>> new file mode 100644
>> index 0000000..66ff588
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/net/qca-qca7000-spi.txt
>> @@ -0,0 +1,47 @@
>> +* Qualcomm QCA7000 (Ethernet over SPI protocol)
>> +
>> +Note: The QCA7000 is useable as a SPI device. In this case it must
>> be defined
>> +as a child of a SPI master in the device tree.
>> +
>> +Required properties:
>> +- compatible : Should be "qca,qca7000"
>> +- reg : Should specify the SPI chip select
>> +- interrupt-parent : Should specify the pHandle of the source interrupt
>
> This property is not really required, it could be inherited from an
> upper-level node.
should i move this property to the optional properties or drop it from
the properties?
>
>> +- interrupts : The first cell should specify the index of the source
>> interrupt
>> + and the second cell should specify the trigger type as rising edge
>> +- spi-cpha : Must be set
>> +- spi-cpol: Must be set
>> +
>> +Optional properties:
>> +- spi-max-frequency : Maximum frequency of the SPI bus the chip can
>> operate at.
>> + Numbers smaller than 1000000 or greater than 16000000 are invalid.
>> Missing
>> + the property will set the SPI frequency to 8000000 Hertz.
>> +- local-mac-address: 6 bytes, mac address
>
> s/mac/MAC/.
I assume that the replacement should apply only to the property
description not to the property name.
>
>
>> +- qca,legacy-mode : Set the SPI data transfer of the QCA7000 to
>> legacy mode.
>> + In this mode the SPI master must toggle the chip select between
>> each data
>> + word. In burst mode these gaps aren't necessary, which is faster.
>> + This setting depends on how the QCA7000 is setup via GPIO pin
>> strapping.
>> + If the property is missing the driver defaults to burst mode.
>> +
>> +Example:
>> +
>> +/* Freescale i.MX28 SPI master*/
>> +ssp2: ssp@80014000 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + compatible = "fsl,imx28-spi";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&spi2_pins_a>;
>> + status = "okay";
>> +
>> + qca7000@0 {
>
> According to the ePAPR standard [1]:
>
> The name of a node should be somewhat generic, reflecting the function
> of the device and not its precise programming model. If appropriate,
> the name should be one of the following choices:
> [...]
> - ethernet;
I have doubts about that. I agree that the current node name doesn't fit
to ePAPR. The function of a QCA7000 isn't really a ethernet device. Yes,
this linux driver implementation handle the QCA7000 as a ethernet
device. But the QCA7000 a powerline device according to Homeplug GreenPHY.
How about using powerline as node name?
>
>> + compatible = "qca,qca7000";
>> + interrupt-parent = <&gpio3>; /* GPIO Bank 3 */
>> + interrupts = <25 0x1>; /* Index: 25, rising edge */
>> + reg = <0x0>;
>> + spi-cpha; /* SPI mode: CPHA=1 */
>> + spi-cpol; /* SPI mode: CPOL=1 */
>> + spi-max-frequency = <8000000>; /* freq: 8 MHz */
>> + local-mac-address = [ A0 B0 C0 D0 E0 F0 ];
>> + };
>> +};
>
> [1]
> http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
>
> WBR, Sergei
>
BR Stefan Wahren
next prev parent reply other threads:[~2014-07-02 7:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 16:36 [PATCH RFC V2 0/2] add Qualcomm QCA7000 ethernet driver Stefan Wahren
2014-07-01 16:36 ` [PATCH RFC V2 1/2] Documentation: add Device tree bindings for QCA7000 Stefan Wahren
2014-07-01 17:33 ` Sergei Shtylyov
2014-07-02 7:01 ` Stefan Wahren [this message]
2014-07-02 11:51 ` Sergei Shtylyov
2014-07-02 15:37 ` Stefan Wahren
2014-07-01 16:36 ` [PATCH RFC V2 2/2] net: qualcomm: new Ethernet over SPI driver " Stefan Wahren
2014-07-01 17:37 ` Joe Perches
2014-07-01 17:46 ` Mark Rutland
2014-07-01 17:57 ` Joe Perches
2014-07-01 18:16 ` Mark Rutland
2014-07-03 9:49 ` Tobias Klauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B3AE5C.6040005@i2se.com \
--to=stefan.wahren@i2se$(echo .)com \
--cc=dave.taht@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=galak@codeaurora$(echo .)org \
--cc=ijc+devicetree@hellion$(echo .)org.uk \
--cc=mark.rutland@arm$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pawel.moll@arm$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox