From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Mark Rutland <mark.rutland@arm•com>,
Marc Kleine-Budde <mkl@pengutronix•de>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"wg@grandegger•com" <wg@grandegger•com>,
"linux-can@vger•kernel.org" <linux-can@vger•kernel.org>,
"robh+dt@kernel•org" <robh+dt@kernel•org>,
Pawel Moll <Pawel.Moll@arm•com>,
"ijc+devicetree@hellion•org.uk" <ijc+devicetree@hellion•org.uk>,
"galak@codeaurora•org" <galak@codeaurora•org>,
"grant.likely@linaro•org" <grant.likely@linaro•org>,
"devicetree@vger•kernel.org" <devicetree@vger•kernel.org>,
"linux-sh@vger•kernel.org" <linux-sh@vger•kernel.org>,
"vksavl@gmail•com" <vksavl@gmail•com>,
"rdunlap@infradead•org" <rdunlap@infradead•org>,
"linux-doc@vger•kernel.org" <linux-doc@vger•kernel.org>
Subject: Re: [PATCH] rcar_can: add device tree support
Date: Thu, 03 Jul 2014 00:26:07 +0400 [thread overview]
Message-ID: <53B46ADF.9070602@cogentembedded.com> (raw)
In-Reply-To: <20140702101437.GC14665@leverpostej>
Hello.
On 07/02/2014 02:14 PM, Mark Rutland wrote:
>>> Add support of the device tree probing for the Renesas R-Car CAN controllers
>>> documenting the device tree bindings as necessary.
[...]
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
[...]
>>> Index: net-next/Documentation/devicetree/bindings/net/can/rcar_can.txt
>>> ===================================================================
>>> --- /dev/null
>>> +++ net-next/Documentation/devicetree/bindings/net/can/rcar_can.txt
>>> @@ -0,0 +1,40 @@
[...]
>>> +- reg: physical base address and size of the R-Car CAN register map.
>>> +- interrupts: interrupt specifier for the sole interrupt.
>>> +- clocks: phandle and clock specifier for the R-Car CAN clock input.
>>> +- pinctrl-0: pin control group to be used for this controller.
>>> +- pinctrl-names: must be "default".
>>> +
>>> +Optional properties:
>>> +- clock-select: R-Car CAN Clock Source Select. Valid values are:
>>> + <0x0> (default) : Peripheral clock (clkp1)
>>> + <0x1> : Peripheral clock (clkp2)
>>> + <0x3> : Externally input clock
> What's this for, and how does this interact with the single clock listed
> above?
That's supposed to select a source for the CAN bus clock. Looking back at
the driver, it seems to actually only support the value of 0. That's something
we haven't given enough attention to clearly... :-/
> THanks,
> Mark.
WBR, Sergei
next prev parent reply other threads:[~2014-07-02 20:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 22:27 [PATCH] rcar_can: add device tree support Sergei Shtylyov
2014-07-01 22:50 ` Marc Kleine-Budde
2014-07-02 10:14 ` Mark Rutland
2014-07-02 20:26 ` Sergei Shtylyov [this message]
2014-07-02 21:43 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B46ADF.9070602@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=Pawel.Moll@arm$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=galak@codeaurora$(echo .)org \
--cc=grant.likely@linaro$(echo .)org \
--cc=ijc+devicetree@hellion$(echo .)org.uk \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=mkl@pengutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rdunlap@infradead$(echo .)org \
--cc=robh+dt@kernel$(echo .)org \
--cc=vksavl@gmail$(echo .)com \
--cc=wg@grandegger$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox