From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
To: Thomas Graf <tgraf@suug•ch>, Tom Herbert <therbert@google•com>
Cc: Linux Netdev List <netdev@vger•kernel.org>,
Stephen Hemminger <stephen@networkplumber•org>,
Pravin B Shelar <pshelar@nicira•com>,
xiyou.wangcong@gmail•com, Or Gerlitz <ogerlitz@mellanox•com>,
Daniel Borkmann <dborkman@redhat•com>,
"Pritesh Kothari (pritkoth)" <pritkoth@cisco•com>,
Madhu Challa <challa@noironetworks•com>
Subject: Re: [PATCH 1/2 net-next] vxlan: Be liberal on receive and only require the I bit to be set
Date: Tue, 15 Jul 2014 09:18:01 +0200 [thread overview]
Message-ID: <53C4D5A9.1030008@6wind.com> (raw)
In-Reply-To: <20140714081802.GA19186@casper.infradead.org>
Le 14/07/2014 10:18, Thomas Graf a écrit :
> On 07/13/14 at 03:08pm, Tom Herbert wrote:
>> On Fri, Jul 11, 2014 at 9:59 AM, Thomas Graf <tgraf@suug•ch> wrote:
>>> The VXLAN receive code is currently conservative in what it accepts and
>>> will reject any frame that uses any of the reserved fields. The VXLAN
>>> draft specifies that "reserved fields MUST be set to zero on transmit
>>> and ignored on receive." though.
>>>
>>> Be liberal in only requiring the I bit to allow for VXLAN extensions
>>> to be implemented.
>>>
>> This is not robust (this is a problem in the VXLAN spec not your
>> patch). There is no requirement that the VXLAN bits are optional. For
>> example, if a receiver accepts a GPE packet but doesn't implement it
>> the packet will be misinterpreted. I've already pointed this out to
>> the VLXAN folks on nvo3 list. Dropping packets with unknown bits set
>> is the only sane approach.
>
> I agree, it's a mess.
+1
next prev parent reply other threads:[~2014-07-15 7:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 16:59 [PATCH 0/2 net-next] vxlan: Liberal parsing & basic VXLAN-gpe Thomas Graf
2014-07-11 16:59 ` [PATCH 1/2 net-next] vxlan: Be liberal on receive and only require the I bit to be set Thomas Graf
2014-07-11 19:41 ` Stephen Hemminger
2014-07-11 21:28 ` Thomas Graf
2014-07-14 8:46 ` David Laight
2014-07-13 22:08 ` Tom Herbert
2014-07-14 8:18 ` Thomas Graf
2014-07-15 7:18 ` Nicolas Dichtel [this message]
2014-07-11 16:59 ` [PATCH 2/2 net-next] vxlan: Minimal support for Generic Protocol Extension (VXLAN-gpe) Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C4D5A9.1030008@6wind.com \
--to=nicolas.dichtel@6wind$(echo .)com \
--cc=challa@noironetworks$(echo .)com \
--cc=dborkman@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=pritkoth@cisco$(echo .)com \
--cc=pshelar@nicira$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=tgraf@suug$(echo .)ch \
--cc=therbert@google$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox