From: Edward Cree <ecree@solarflare•com>
To: Varka Bhadram <varkabhadram@gmail•com>
Cc: <netdev@vger•kernel.org>, Dave Miller <davem@davemloft•net>,
<linux-net-drivers@solarflare•com>
Subject: Re: [PATCH net-next] sfc: add extra RX drop counters for nodesc_trunc and noskb_drop
Date: Tue, 15 Jul 2014 13:21:43 +0100 [thread overview]
Message-ID: <53C51CD7.3030105@solarflare.com> (raw)
In-Reply-To: <53C50C35.80200@gmail.com>
On 15/07/14 12:10, Varka Bhadram wrote:
> On 07/15/2014 04:28 PM, Edward Cree wrote:
>> Added a counter rx_noskb_drop for failure to allocate an skb.
>> Summed the per-channel rx_nodesc_trunc counters earlier so that they can
>> be included in rx_dropped.
>>
>>
> check patch errors on this patch... :-)
>
"Macros with complex values should be enclosed in parenthesis" is a
false positive - the macro is for a structure initialiser.
The long lines are both justifiable and only slightly over 80 columns.
So checkpatch is just being fascist as usual ;)
-Edward
next prev parent reply other threads:[~2014-07-15 12:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 10:58 [PATCH net-next] sfc: add extra RX drop counters for nodesc_trunc and noskb_drop Edward Cree
2014-07-15 11:10 ` Varka Bhadram
2014-07-15 12:21 ` Edward Cree [this message]
2014-07-15 12:32 ` Varka Bhadram
2014-07-16 5:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C51CD7.3030105@solarflare.com \
--to=ecree@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-net-drivers@solarflare$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=varkabhadram@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox