Subject: Re: [PATCH net-next] bonding: fix bond_option_mode_set warning

From: Nikolay Aleksandrov <[email-masked]>
Date: Tue, 15 Jul 2014 16:13:49 +0200

On 07/15/2014 04:08 PM, Nikolay Aleksandrov wrote:
> During the conversion to "static" functions this one got left out, only its
> prototype was converted, thus resulting in:
> drivers/net/bonding//bond_options.c:674:5: warning: symbol
> 'bond_option_mode_set' was not declared. Should it be static?
> 
> Fix it by making it static and also break the line in two as it was too
> long.
> 
> CC: Stephen Hemminger <[email-masked]>
> CC: Jay Vosburgh <[email-masked]>
> CC: Veaceslav Falico <[email-masked]>
> CC: Andy Gospodarek <[email-masked]>
> CC: David S. Miller <[email-masked]>
> 
> Signed-off-by: Nikolay Aleksandrov <[email-masked]>
> ---

Just FYI, I targeted this at net-next as it's more cosmetic and there aren't any
real side-effects because of it. In case you decide it's more appropriate for
-net, the commit that did this was:
f3253339a47f ("bonding: options handling cleanup")

and I tested that this patch applies cleanly to -net, so it's fit for there too.

Cheers,
 Nik