From: Casey Leedom <leedom@chelsio•com>
To: Anish Bhatt <anish@chelsio•com>, netdev@vger•kernel.org
Cc: davem@davemloft•net, hariprasad@chelsio•com, dan.carpenter@oracle•com
Subject: Re: [PATCH net-next] cxgb4: Fix static checker warnings
Date: Tue, 15 Jul 2014 14:57:38 -0700 [thread overview]
Message-ID: <53C5A3D2.6090401@chelsio.com> (raw)
In-Reply-To: <1405451843-3081-1-git-send-email-anish@chelsio.com>
While it's great to fix these warnings, it seems like this might be
going in the wrong direction.
Currently only the cxgb4 and bnx2x drivers offer (struct
dcbnl_rtnl_ops).setapp() calls. The bnx2x driver also returns -EINVAL,
etc. Meanwhile, the only call to the .setapp() entry is in
dcbnl_setapp() and it stores the result back into an int "ret". It
strikes me that the real bug may be an incorrect "u8" return type for
the .setapp() prototype in include/net/dcbnl.h. The prototype was added
in commit 7114323b almost 5 years ago so I'm not sure if the original
author, Yi Zou <yi.zou@intel•com>, will be around to offer backing
information on this ...
Casey
On 07/15/14 12:17, Anish Bhatt wrote:
> This patch fixes static checker warnings as pointed out on by Dan Carpenter
>
> Fixes: 76bcb31efc06 ("cxgb4 : Add DCBx support codebase and dcbnl_ops")
> Signed-off-by: Anish Bhatt <anish@chelsio•com>
> ---
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c
> index a8b1073e6373..8734dfe0da32 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c
> @@ -676,15 +676,15 @@ static u8 cxgb4_setapp(struct net_device *dev, u8 app_idtype, u16 app_id,
>
>
> if (pi->dcb.state != CXGB4_DCB_STATE_FW_ALLSYNCED)
> - return -EINVAL;
> + return 0;
>
> /* DCB info gets thrown away on link up */
> if (!netif_carrier_ok(dev))
> - return -ENOLINK;
> + return 0;
>
> if (app_idtype != DCB_APP_IDTYPE_ETHTYPE &&
> app_idtype != DCB_APP_IDTYPE_PORTNUM)
> - return -EINVAL;
> + return 0;
>
> for (i = 0; i < CXGB4_MAX_DCBX_APP_SUPPORTED; i++) {
> INIT_PORT_DCB_READ_LOCAL_CMD(pcmd, pi->port_id);
> @@ -710,7 +710,7 @@ static u8 cxgb4_setapp(struct net_device *dev, u8 app_idtype, u16 app_id,
> if (i == CXGB4_MAX_DCBX_APP_SUPPORTED) {
> /* no empty slots available */
> dev_err(adap->pdev_dev, "DCB app table full\n");
> - return -EBUSY;
> + return 0;
> }
>
> /* write out new app table entry */
next prev parent reply other threads:[~2014-07-15 21:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 19:17 [PATCH net-next] cxgb4: Fix static checker warnings Anish Bhatt
2014-07-15 21:57 ` Casey Leedom [this message]
2014-07-16 22:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C5A3D2.6090401@chelsio.com \
--to=leedom@chelsio$(echo .)com \
--cc=anish@chelsio$(echo .)com \
--cc=dan.carpenter@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=hariprasad@chelsio$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox