Subject: Re: [PATCH net] net: sctp: inherit auth_capable on INIT collisions

From: Daniel Borkmann <[email-masked]>
Date: Fri, 18 Jul 2014 21:17:18 +0200

On 07/18/2014 04:38 PM, Vlad Yasevich wrote:
...
> Why is the original value of asoc->peer.auth_capable = 0?
> In case of collision, asoc is the old association that
> existed on the system.  That association was created as part of
> sending the INIT.  If it is processing a duplicate COOKIE-ECHO
> as you say, then it has already processed the INIT-ACK and
> should have determined that the peer is auth capable.
>
> Thus the capability of the new and the old associations should
> be same if we are in fact processing case B (collision).
>
> If not, then something else if wrong and my guess is that all
> other capabilities would be wrong too.

I agree that they might likely also be flawed.

Ok, let me dig further.