From: Christoph Schulz <develop@kristov•de>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, linux-ppp@vger•kernel.org,
paulus@samba•org, isdn@linux-pingi•de
Subject: Re: [PATCH net v2 1/1] net: ppp: don't call sk_chk_filter twice
Date: Fri, 18 Jul 2014 23:34:50 +0200 [thread overview]
Message-ID: <53C992FA.4040204@kristov.de> (raw)
In-Reply-To: <20140714.161523.399591287185710608.davem@davemloft.net>
Hello!
Am 15.07.2014 01:15, schrieb David Miller:
> From: Christoph Schulz <develop@kristov•de>
> Date: Mon, 14 Jul 2014 08:01:10 +0200
>
>> From: Christoph Schulz <develop@kristov•de>
>>
>> Commit 568f194e8bd16c353ad50f9ab95d98b20578a39d ("net: ppp: use
>> sk_unattached_filter api") causes sk_chk_filter() to be called twice when
>> setting a PPP pass or active filter. This applies to both the generic PPP
>> subsystem implemented by drivers/net/ppp/ppp_generic.c and the ISDN PPP
>> subsystem implemented by drivers/isdn/i4l/isdn_ppp.c. The first call is from
>> within get_filter().
>> [...]
>> For 3.15.x, this proposed change is a bugfix rather than a pure optimization as
>> in that branch, sk_chk_filter() may replace filter codes by other codes which
>> are not recognized when executing sk_chk_filter() a second time. So with
>> 3.15.x, if sk_chk_filter() is called twice, the second invocation may yield
>> EINVAL (this depends on the filter codes found in the filter to be set, but
>> because the replacement is done for frequently used codes, this is almost
>> always the case). The net effect is that setting pass and/or active PPP filters
>> does not work anymore, since sk_unattached_filter_create() always returns
>> EINVAL due to the second call to sk_chk_filter(), regardless whether the filter
>> was originally sane or not.
>>
>> Signed-off-by: Christoph Schulz <develop@kristov•de>
>
> Applied, thank you.
As the commit message says, this patch is a bugfix for the 3.15.y
branch. However, I don't see it in the netdev stable-queue. Could you
please add it to -stable for 3.15.y?
Thank you in advance,
Christoph Schulz
next prev parent reply other threads:[~2014-07-18 21:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 6:01 [PATCH net v2 1/1] net: ppp: don't call sk_chk_filter twice Christoph Schulz
2014-07-14 7:17 ` Daniel Borkmann
2014-07-14 23:15 ` David Miller
2014-07-18 21:34 ` Christoph Schulz [this message]
2014-07-21 4:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C992FA.4040204@kristov.de \
--to=develop@kristov$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=isdn@linux-pingi$(echo .)de \
--cc=linux-ppp@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox