Subject: Re: [PATCH net-next v7 1/6] openvswitch: Allow each vport to have an array of 'port_id's.

From: Varka Bhadram <[email-masked]>
Date: Tue, 22 Jul 2014 12:23:35 +0530

On 07/22/2014 11:59 AM, Pravin B Shelar wrote:
> From: Alex Wang <[email-masked]>
>
> In order to allow handlers directly read upcalls from datapath,
> we need to support per-handler netlink socket for each vport in
> datapath.  This commit makes this happen.  Also, it is guaranteed
> to be backward compatible with previous branch.
>
> Signed-off-by: Alex Wang <[email-masked]>
> Acked-by: Thomas Graf <[email-masked]>
> Signed-off-by: Pravin B Shelar <[email-masked]>
> ---
>   include/uapi/linux/openvswitch.h | 13 ++++--
>   net/openvswitch/datapath.c       | 21 ++++++---
>   net/openvswitch/vport.c          | 99 +++++++++++++++++++++++++++++++++++++++-
>   net/openvswitch/vport.h          | 27 +++++++++--
>   4 files changed, 144 insertions(+), 16 deletions(-)

WARNING: line over 80 characters

#67: FILE: net/openvswitch/datapath.c:1635:

+        nla_put_string(skb, OVS_VPORT_ATTR_NAME, vport->ops->get_name(vport)))

WARNING: line over 80 characters

#99: FILE: net/openvswitch/datapath.c:1820:

+                           a[OVS_VPORT_ATTR_UPCALL_PID]);

WARNING: line over 80 characters

#226: FILE: net/openvswitch/vport.c:423:

+    return ids->ids[hash - ids->n_ids * reciprocal_divide(hash, ids->rn_ids)];

-- 
Regards,
Varka Bhadram.