Subject: Re: [PATCH net-next v2 1/2] ethernet: realtek: use module_pci_driver

From: Sergei Shtylyov <[email-masked]>
Date: Tue, 22 Jul 2014 19:01:25 +0400

On 07/22/2014 06:43 PM, Varka Bhadram wrote:

>>> From: Varka Bhadram <[email-masked]>

>>> This patch converts to use the macro module_pci_driver, which makes
>>> the code smaller and simpler.

>>> Signed-off-by: Varka Bhadram <[email-masked]>
>>> ---
>>>   drivers/net/ethernet/realtek/8139cp.c |   22 ++--------------------
>>>   1 file changed, 2 insertions(+), 20 deletions(-)

>>> diff --git a/drivers/net/ethernet/realtek/8139cp.c
>>> b/drivers/net/ethernet/realtek/8139cp.c
>>> index 2bc728e..9fb68b9 100644
>>> --- a/drivers/net/ethernet/realtek/8139cp.c
>>> +++ b/drivers/net/ethernet/realtek/8139cp.c
>>> @@ -1887,11 +1887,7 @@ static int cp_init_one (struct pci_dev *pdev, const
>>> struct pci_device_id *ent)
>>>       resource_size_t pciaddr;
>>>       unsigned int addr_len, i, pci_using_dac;
>>>
>>> -#ifndef MODULE
>>> -    static int version_printed;
>>> -    if (version_printed++ == 0)
>>> -        pr_info("%s", version);
>>> -#endif
>>> +    pr_info("%s", version);

>>    Use pr_info_once().

>> WBR, Sergei

> I am going to utilize the removed code by removing the #ifndef MODULE...

> It will be like:
>
>      static int version_printed;
>
>      if (version_printed++ == 0)
>          pr_info("%s", version);

    pr_info_once() is much shorter and the effect is the same.

WBR, Sergei