From: Jiang Liu <jiang.liu@linux•intel.com>
To: Nishanth Aravamudan <nacc@linux•vnet.ibm.com>,
Alexander Duyck <alexander.duyck@gmail•com>
Cc: Andrew Morton <akpm@linux-foundation•org>,
Mel Gorman <mgorman@suse•de>,
David Rientjes <rientjes@google•com>,
Mike Galbraith <umgwanakikbuti@gmail•com>,
Peter Zijlstra <peterz@infradead•org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel•com>,
Jeff Kirsher <jeffrey.t.kirsher@intel•com>,
Jesse Brandeburg <jesse.brandeburg@intel•com>,
Bruce Allan <bruce.w.allan@intel•com>,
Carolyn Wyborny <carolyn.wyborny@intel•com>,
Don Skidmore <donald.c.skidmore@intel•com>,
Greg Rose <gregory.v.rose@intel•com>,
Alex Duyck <alexander.h.duyck@intel•com>,
John Ronciak <john.ronciak@intel•com>,
Mitch Williams <mitch.a.williams@intel•com>,
Linux NICS <linux.nics@intel•com>,
Tony Luck <tony.luck@intel•com>,
linux-mm@kvack•org, linux-hotplug@vger•kernel.org,
linux-kernel@vger•kernel.org, e1000-devel@lists•sourceforge.net,
Netdev <netdev@vger•kernel.org>
Subject: Re: [RFC Patch V1 15/30] mm, igb: Use cpu_to_mem()/numa_mem_id() to support memoryless node
Date: Wed, 23 Jul 2014 11:20:20 +0800 [thread overview]
Message-ID: <53CF29F4.7040700@linux.intel.com> (raw)
In-Reply-To: <20140721210900.GI4156@linux.vnet.ibm.com>
Hi Nishanth and Alexander,
Thanks for review, will update the comments
in next version.
Regards!
Gerry
On 2014/7/22 5:09, Nishanth Aravamudan wrote:
> On 21.07.2014 [12:53:33 -0700], Alexander Duyck wrote:
>> I do agree the description should probably be changed. There shouldn't be
>> any panics involved, only a performance impact as it will be reallocating
>> always if it is on a node with no memory.
>
> Yep, thanks for the review.
>
>> My intention on this was to make certain that the memory used is from the
>> closest node possible. As such I believe this change likely honours that.
>
> Absolutely, just wanted to make it explicit that it's not a functional
> fix, just a performance fix (presuming this shows up at all on systems
> that have memoryless NUMA nodes).
>
> I'd suggest an update to the comments, as well.
>
> Thanks,
> Nish
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack•org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack•org"> email@kvack•org </a>
next prev parent reply other threads:[~2014-07-23 3:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1405064267-11678-1-git-send-email-jiang.liu@linux.intel.com>
2014-07-11 7:37 ` [RFC Patch V1 03/30] mm, net: Use cpu_to_mem()/numa_mem_id() to support memoryless node Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 04/30] mm, netfilter: " Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 10/30] mm, xfrm: " Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 13/30] mm, i40e: " Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 14/30] mm, i40evf: " Jiang Liu
2014-07-11 7:37 ` [RFC Patch V1 15/30] mm, igb: " Jiang Liu
2014-07-21 17:42 ` Nishanth Aravamudan
2014-07-21 19:53 ` Alexander Duyck
2014-07-21 21:09 ` Nishanth Aravamudan
2014-07-23 3:20 ` Jiang Liu [this message]
2014-07-11 7:37 ` [RFC Patch V1 16/30] mm, ixgbe: " Jiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CF29F4.7040700@linux.intel.com \
--to=jiang.liu@linux$(echo .)intel.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alexander.duyck@gmail$(echo .)com \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=bruce.w.allan@intel$(echo .)com \
--cc=carolyn.wyborny@intel$(echo .)com \
--cc=donald.c.skidmore@intel$(echo .)com \
--cc=e1000-devel@lists$(echo .)sourceforge.net \
--cc=gregory.v.rose@intel$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=john.ronciak@intel$(echo .)com \
--cc=linux-hotplug@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux.nics@intel$(echo .)com \
--cc=mgorman@suse$(echo .)de \
--cc=mitch.a.williams@intel$(echo .)com \
--cc=nacc@linux$(echo .)vnet.ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peterz@infradead$(echo .)org \
--cc=rafael.j.wysocki@intel$(echo .)com \
--cc=rientjes@google$(echo .)com \
--cc=tony.luck@intel$(echo .)com \
--cc=umgwanakikbuti@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox