Subject: Re: [PATCH 2/6] net/macb: add scatter-gather hw feature

From: Cyrille Pitchen <[email-masked]>
Date: Wed, 23 Jul 2014 09:45:12 +0200

Le 21/07/2014 06:13, David Miller a écrit :
> From: Cyrille Pitchen <[email-masked]>
> Date: Fri, 18 Jul 2014 16:21:14 +0200
> 
>> +		if (tx_skb->mapped_as_page) {
>> +			dma_unmap_page(&bp->pdev->dev, tx_skb->mapping,
>> +				       tx_skb->size, DMA_TO_DEVICE);
>> +		} else {
>> +			dma_unmap_single(&bp->pdev->dev, tx_skb->mapping,
>> +					 tx_skb->size, DMA_TO_DEVICE);
>> +		}
> 
> Please do not use curly braces for basic block composed of a single statement.
> 
Hi David,

thanks for your review, I'll fix it in the next series of patch.

Regards,

Cyrille