Subject: Re: [PATCH] isdn/bas_gigaset: fix a leak on failure path in gigaset_probe()

From: Tilman Schmidt <[email-masked]>
Date: Sat, 26 Jul 2014 12:23:06 +0200

Am 26.07.2014 00:34, schrieb Alexey Khoroshilov:
> There is a lack of usb_put_dev(udev) on failure path in gigaset_probe().

You're right. Good catch.

> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <[email-masked]>

Acked-by: Tilman Schmidt <[email-masked]>

> ---
>  drivers/isdn/gigaset/bas-gigaset.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/isdn/gigaset/bas-gigaset.c b/drivers/isdn/gigaset/bas-gigaset.c
> index c44950d3eb7b..b7ae0a0dd5b6 100644
> --- a/drivers/isdn/gigaset/bas-gigaset.c
> +++ b/drivers/isdn/gigaset/bas-gigaset.c
> @@ -2400,6 +2400,7 @@ allocerr:
>  error:
>  	freeurbs(cs);
>  	usb_set_intfdata(interface, NULL);
> +	usb_put_dev(udev);
>  	gigaset_freecs(cs);
>  	return rc;
>  }
> 

-- 
Tilman Schmidt                              E-Mail: [email-masked]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)