From: Duan Jiong <duanj.fnst@cn•fujitsu.com>
To: Hannes Frederic Sowa <hannes@stressinduktion•org>
Cc: David Miller <davem@davemloft•net>, <eric.dumazet@gmail•com>,
netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH v2] net: fix the counter ICMP_MIB_INERRORS/ICMP6_MIB_INERRORS
Date: Fri, 1 Aug 2014 09:09:17 +0800 [thread overview]
Message-ID: <53DAE8BD.30907@cn.fujitsu.com> (raw)
In-Reply-To: <1406840726.13603.3.camel@localhost>
On 08/01/2014 05:05 AM, Hannes Frederic Sowa wrote:
> On Do, 2014-07-31 at 17:54 +0800, Duan Jiong wrote:
>> When dealing with ICMPv[46] Error Message, function icmp_socket_deliver()
>> and icmpv6_notify() do some valid checks on packet's length, but then some
>> protocols check packet's length redaudantly. So remove those duplicated
>> statements, and increase counter ICMP_MIB_INERRORS/ICMP6_MIB_INERRORS in
>> function icmp_socket_deliver() and icmpv6_notify() respectively.
>>
>> In addition, add missed counter in udp6/udplite6 when socket is NULL.
>>
>> Signed-off-by: Duan Jiong <duanj.fnst@cn•fujitsu.com>
>> ---
>>
>> v2: remove nested rcu_read_lock from icmpv6_notify
>
> Acked-by: Hannes Frederic Sowa <hannes@stressinduktion•org>
>
> IPv4 handler can also be cleaned up. ;)
Ok, i will make another patch soon. :)
Thanks,
Duan
>
> Thanks!
>
>
next prev parent reply other threads:[~2014-08-01 1:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 8:19 [PATCH] net: fix the counter ICMP_MIB_INERRORS/ICMP6_MIB_INERRORS Duan Jiong
2014-07-30 13:45 ` Hannes Frederic Sowa
2014-07-31 2:58 ` Duan Jiong
2014-07-31 7:52 ` Hannes Frederic Sowa
2014-07-31 8:34 ` Duan Jiong
2014-07-31 9:10 ` Hannes Frederic Sowa
2014-07-31 9:54 ` [PATCH v2] " Duan Jiong
2014-07-31 21:05 ` Hannes Frederic Sowa
2014-08-01 1:09 ` Duan Jiong [this message]
2014-08-01 5:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DAE8BD.30907@cn.fujitsu.com \
--to=duanj.fnst@cn$(echo .)fujitsu.com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=hannes@stressinduktion$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox