Subject: Re: [PATCH] r8152: add missing Makefile rule

From: [email-masked]
Date: Sun, 03 Aug 2014 09:52:58 +0200

On 03/08/14 05:41 AM, David Miller wrote:
> From: [email-masked]
> Date: Sat, 02 Aug 2014 01:26:40 +0200
> 
>>  Is seems that this issue has existed ever since the driver was
>>  added back in 3.10. In Linus' git tree the drivers/net/Makefile was
>>  last modified before the inclusion of the driver, so I don't know
>>  if it's ever been possible to build it.
> 
> It gets built, as long as at least one other USB networking driver has
> been selected.
> 
> Most people (distributions, developers, maintainers) select all
> drivers or some large subset thereof, so would never actually run into
> this problem.
> 
> You'd have to specifically have a configuration that enabled r8152 and
> no other USB networking driver, in order to trigger this.
> 
> Anyways, I'll apply this, thanks.

Very true, thank you for pointing it out. If you haven't done so yet,
the patch description could be changed to something like:

When it is the only USB net driver selected, the r8152 driver doesn't
get built because of a missing rule in drivers/net/Makefile. This change
adds the rule and lets the driver build.

Thank you!
JF