Subject: Re: [PATCH] tcp: md5: remove unneeded check in tcp_v4_parse_md5_keys

From: YOSHIFUJI Hideaki <[email-masked]>
Date: Mon, 04 Aug 2014 09:05:55 +0900

Dmitry Popov wrote:
> tcpm_key is an array inside struct tcp_md5sig, there is no need to check it
> against NULL.
>
> Signed-off-by: Dmitry Popov <[email-masked]>

Acked-by: YOSHIFUJI Hideaki <[email-masked]>

(IPv6 side is okay.)

> ---
>   net/ipv4/tcp_ipv4.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
> index 77cccda..8ea4eff 100644
> --- a/net/ipv4/tcp_ipv4.c
> +++ b/net/ipv4/tcp_ipv4.c
> @@ -1064,7 +1064,7 @@ static int tcp_v4_parse_md5_keys(struct sock *sk, char __user *optval,
>   	if (sin->sin_family != AF_INET)
>   		return -EINVAL;
>
> -	if (!cmd.tcpm_key || !cmd.tcpm_keylen)
> +	if (!cmd.tcpm_keylen)
>   		return tcp_md5_do_del(sk, (union tcp_md5_addr *)&sin->sin_addr.s_addr,
>   				      AF_INET);
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to [email-masked]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

--yoshfuji