From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: David Hollis <dhollis@davehollis•com>, netdev@vger•kernel.org
Subject: Re: [PATCH] asix - Add support for LyconSys FiberGecko
Date: Thu, 07 Aug 2014 20:33:53 +0400 [thread overview]
Message-ID: <53E3AA71.5070201@cogentembedded.com> (raw)
In-Reply-To: <1407426826-11335-2-git-send-email-dhollis@davehollis.com>
Hello.
On 08/07/2014 07:53 PM, David Hollis wrote:
> Reported-by: Sven Kreiensen <s.kreiensen@lyconsys•com>
> Signed-off-by: David Hollis <dhollis@davehollis•com>
> ---
> drivers/net/usb/asix_devices.c | 25 ++++++++++++++++++++++++-
> 1 file changed, 24 insertions(+), 1 deletion(-)
> diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
> index 5d19409..d09f2ea 100644
> --- a/drivers/net/usb/asix_devices.c
> +++ b/drivers/net/usb/asix_devices.c
[...]
> @@ -648,6 +648,12 @@ static int ax88178_reset(struct usbnet *dev)
> asix_sw_reset(dev, 0);
> msleep(150);
>
> + /* LyconSys FiberGecko: Turn on PHY */
> + if (dev->driver_info->flags == 0x20061201) {
Hm, don't use magic values please. Doesn't the flags get assigned a
combination of FLAG_* values below? Or you mixed up 'flags' and 'data' fields?
> + /* Power on Phy: set gpio2=high */
> + asix_write_gpio(dev, AX_GPIO_GPO2EN | AX_GPIO_GPO_2, 50);
> + }
> +
> asix_sw_reset(dev, AX_SWRESET_PRL | AX_SWRESET_IPPD);
> msleep(150);
>
> @@ -946,6 +952,19 @@ static const struct driver_info hg20f9_info = {
> .data = FLAG_EEPROM_MAC,
> };
>
> +static const struct driver_info lyconsys_fibergecko100_info = {
> + .description = "LyconSys FiberGecko 100 USB 2.0 to Ethernet Adapter",
> + .bind = ax88178_bind,
> + .status = asix_status,
> + .link_reset = ax88178_link_reset,
> + .reset = ax88178_link_reset,
> + .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_LINK_INTR |
> + FLAG_MULTI_PACKET,
> + .rx_fixup = asix_rx_fixup_common,
> + .tx_fixup = asix_tx_fixup,
Hm, why this sudden change of the initializer style?
> + .data = 0x20061201,
> +};
> +
WBR, Sergei
next prev parent reply other threads:[~2014-08-07 16:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 15:53 [PATCH] asix - Add support for LyconSys FiberGecko David Hollis
2014-08-07 15:53 ` David Hollis
2014-08-07 16:33 ` Sergei Shtylyov [this message]
2025-01-26 11:42 ` [PATCH] net: usb: asix: add FiberGecko DeviceID Max Schulze
2025-01-26 12:12 ` [PATCH v2] " Max Schulze
2025-01-26 16:20 ` Greg KH
2025-01-26 16:33 ` Andrew Lunn
2025-02-12 15:09 ` [PATCH net v3] net: usb: asix_devices: " Max Schulze
2025-02-14 21:23 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E3AA71.5070201@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=dhollis@davehollis$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox