Subject: Re: [PATCH v2] myri10ge: check for DMA mapping errors

From: Hyong-Youb Kim <[email-masked]>
Date: Tue, 12 Aug 2014 19:04:24 +0900

On 8/12/2014 5:35 PM, Stanislaw Gruszka wrote:
> On IOMMU systems DMA mapping can fail, we need to check for
> that possibility.
>
> Signed-off-by: Stanislaw Gruszka <[email-masked]>
> ---
> v1 -> v2: check also for errors on myri10ge_xmit()

It looks okay to me.

>   abort_linearize:
[...]
> -	tx->info[idx].skb = NULL;

I think this last line was a bug.  Thanks for fixing this too.  It would 
lead the code below to call pci_unmap_page() on the header buffer.  It 
should call pci_unmap_single() instead.

> -	do {
[...]
> -			if (tx->info[idx].skb != NULL)
> -				pci_unmap_single(mgp->pdev,
[...]
> -			else
> -				pci_unmap_page(mgp->pdev,