From: wangyufen <wangyufen@huawei•com>
To: David Miller <davem@davemloft•net>
Cc: <netdev@vger•kernel.org>, <stable@vger•kernel.org>
Subject: Re: your netlink permission checks backport to v3.4
Date: Fri, 15 Aug 2014 17:52:08 +0800 [thread overview]
Message-ID: <53EDD848.6090709@huawei.com> (raw)
In-Reply-To: <20140807.135339.1840856785990746406.davem@davemloft.net>
On 2014/8/8 4:53, David Miller wrote:
>
> I don't think you properly compile tested this code:
>
> diff --git a/net/decnet/dn_dev.c b/net/decnet/dn_dev.c
> index c00e307..b79ce1e 100644
> --- a/net/decnet/dn_dev.c
> +++ b/net/decnet/dn_dev.c
> @@ -440,7 +440,7 @@ int dn_dev_ioctl(unsigned int cmd, void __user *arg)
> case SIOCGIFADDR:
> break;
> case SIOCSIFADDR:
> - if (!capable(CAP_NET_ADMIN))
> + if (!netlink_capable(skb, CAP_NET_ADMIN))
> return -EACCES;
> if (sdn->sdn_family != AF_DECnet)
> return -EINVAL;
>
> There is no "skb" variable in this function.
>
> I think we're at the point where this backport makes no sense to submit
> to the -stable tree.
>
> Multiple rounds of attempting to backport these changes has been tries
> and all such attempts have had problems. Compile problems, authorship
> errors, lack of follow-up bug fixes, etc.
>
> This is why I did not try to backport these changes to v3.4 and
> earlier. The possiblity for introducing more regressions is larger
> than the benefit from including these changes.
>
> Please do not ask me to include this backport into my v3.4 -stable
> series submissions any longer, thank you.
>
> Sorry.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
I did not open the CONFIG_DECNET option and the code did not build-in.
It's my first time to do backport. I'm ashamed that I made so many mistakes.
Sincerely sorry to trouble you so much.
prev parent reply other threads:[~2014-08-15 9:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 20:53 your netlink permission checks backport to v3.4 David Miller
2014-08-15 9:52 ` wangyufen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EDD848.6090709@huawei.com \
--to=wangyufen@huawei$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stable@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox