From: Florian Fainelli <f.fainelli@gmail•com>
To: Alexander Duyck <alexander.duyck@gmail•com>, netdev@vger•kernel.org
Cc: davem@davemlof•net, jhs@mojatatu•com, linville@tuxdriver•com,
alexander.h.duyck@intel•com
Subject: Re: [PATCH net-next v3 04/12] net: dsa: retain a per-port device_node pointer
Date: Sun, 24 Aug 2014 19:30:12 -0700 [thread overview]
Message-ID: <53FA9FB4.9050801@gmail.com> (raw)
In-Reply-To: <53FA7607.1080906@gmail.com>
Le 24/08/2014 16:32, Alexander Duyck a écrit :
> On 08/24/2014 11:44 AM, Florian Fainelli wrote:
>> We will later use the per-port device_node pointer to fetch a bunch of
>> port-specific properties.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail•com>
>> ---
>> include/net/dsa.h | 1 +
>> net/dsa/dsa.c | 2 ++
>> net/dsa/slave.c | 1 +
>> 3 files changed, 4 insertions(+)
>>
>> diff --git a/include/net/dsa.h b/include/net/dsa.h
>> index 91d5ba435ab6..66bb036831fd 100644
>> --- a/include/net/dsa.h
>> +++ b/include/net/dsa.h
>> @@ -41,6 +41,7 @@ struct dsa_chip_data {
>> * or any other string to indicate this is a physical port.
>> */
>> char *port_names[DSA_MAX_PORTS];
>> + struct device_node *port_dn[DSA_MAX_PORTS];
>>
>> /*
>> * An array (with nr_chips elements) of which element [a]
>
> It might make sense to place name and device_node pointers members of a
> port struct, and move that array of structs to the end of the
> dsa_chip_data structure.
That's a good point, I will fix that.
--
Florian
next prev parent reply other threads:[~2014-08-25 2:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-24 18:44 [PATCH net-next v3 00/12] dsa: support for Broadcom Starfighter 2 Florian Fainelli
2014-08-24 18:44 ` [PATCH net-next v3 01/12] net: dsa: rework skb->protocol override helpers Florian Fainelli
2014-08-24 18:44 ` [PATCH net-next v3 02/12] net: phy: add generic UniMAC MDIO bus driver Florian Fainelli
2014-08-24 18:44 ` [PATCH net-next v3 03/12] net: dsa: provide a switch device device tree node pointer Florian Fainelli
2014-08-24 18:44 ` [PATCH net-next v3 04/12] net: dsa: retain a per-port device_node pointer Florian Fainelli
2014-08-24 23:32 ` Alexander Duyck
2014-08-25 2:30 ` Florian Fainelli [this message]
2014-08-26 0:51 ` Florian Fainelli
2014-08-24 18:44 ` [PATCH net-next v3 05/12] net: dsa: allow for more complex PHY setups Florian Fainelli
2014-08-24 18:44 ` [PATCH net-next v3 06/12] net: dsa: allow switches to work without tagging Florian Fainelli
2014-08-24 23:27 ` Alexander Duyck
2014-08-24 18:44 ` [PATCH net-next v3 07/12] net: dsa: allow drivers to do link adjustment Florian Fainelli
2014-08-24 18:44 ` [PATCH net-next v3 08/12] net: dsa: allow updating fixed PHY link information Florian Fainelli
2014-08-25 4:56 ` David Miller
2014-08-25 19:33 ` Sergei Shtylyov
2014-08-24 18:44 ` [PATCH net-next v3 09/12] net: dsa: add Broadcom tag RX/TX handler Florian Fainelli
2014-08-24 22:51 ` Alexander Duyck
2014-08-25 2:37 ` Florian Fainelli
2014-08-25 14:51 ` Alexander Duyck
2014-08-24 18:44 ` [PATCH net-next v3 10/12] net: dsa: add Broadcom SF2 switch driver Florian Fainelli
2014-08-24 18:44 ` [PATCH net-next v3 11/12] Documentation: devicetree: update dsa binding with optional properties Florian Fainelli
2014-08-24 18:44 ` [PATCH net-next v3 12/12] Documentation: devicetree: add Broadcom Starfighter 2 binding Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FA9FB4.9050801@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=alexander.duyck@gmail$(echo .)com \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=davem@davemlof$(echo .)net \
--cc=jhs@mojatatu$(echo .)com \
--cc=linville@tuxdriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox