From: Daniel Borkmann <dborkman@redhat•com>
To: David Miller <davem@davemloft•net>
Cc: brouer@redhat•com, netdev@vger•kernel.org
Subject: Re: [RFC PATCH net-next 1/3] ixgbe: support netdev_ops->ndo_xmit_flush()
Date: Tue, 26 Aug 2014 08:13:43 +0200 [thread overview]
Message-ID: <53FC2597.4050501@redhat.com> (raw)
In-Reply-To: <20140825.163135.1716545240924138406.davem@davemloft.net>
On 08/26/2014 01:31 AM, David Miller wrote:
> From: David Miller <davem@davemloft•net>
> Date: Mon, 25 Aug 2014 15:32:48 -0700 (PDT)
>
>> Jesper, just for fun, could you revert all of the xmit flush stuff and
>> test this patch instead?
>
> This doesn't work properly, sorry. We need to explicitly set xmit_more
> to zero before ->ndo_start_xmit() calls, because the initial zero'ing
> of that value isn't propagated in copy_skb_header() (nor do we want to
> add that).
>
> But I'm beyond convinced now that ->ndo_xmit_flush() is not the way to
> do this.
>
> I'm about to post a set of patches which will go into net-next which:
>
> 1) Converts the tree to skb->xmit_more
>
> 2) Adds Daniel's IXGBE conversion, adjusted for xmit_more.
This seems indeed a better, more lightweight version to accomplish it.
next prev parent reply other threads:[~2014-08-26 6:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-24 13:42 [RFC PATCH net-next 0/3] Some deferred TX queue follow-ups Daniel Borkmann
2014-08-24 13:42 ` [RFC PATCH net-next 1/3] ixgbe: support netdev_ops->ndo_xmit_flush() Daniel Borkmann
2014-08-25 5:55 ` David Miller
2014-08-25 12:07 ` Jesper Dangaard Brouer
2014-08-25 22:32 ` David Miller
2014-08-25 23:31 ` David Miller
2014-08-26 6:13 ` Daniel Borkmann [this message]
2014-08-25 22:51 ` Alexander Duyck
2014-08-26 6:44 ` Jesper Dangaard Brouer
2014-08-27 11:34 ` Jesper Dangaard Brouer
2014-08-24 13:42 ` [RFC PATCH net-next 2/3] net: add __netdev_xmit_{only,flush} helpers Daniel Borkmann
2014-08-24 13:42 ` [RFC PATCH net-next 3/3] packet: make use of deferred TX queue flushing Daniel Borkmann
2014-08-25 5:57 ` David Miller
2014-08-25 6:40 ` Daniel Borkmann
2014-08-25 13:54 ` Jesper Dangaard Brouer
2014-08-25 15:16 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FC2597.4050501@redhat.com \
--to=dborkman@redhat$(echo .)com \
--cc=brouer@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox